Skip to content

Changed input validation on login form to passive - #616

Merged
nscuro merged 1 commit into
DependencyTrack:masterfrom
Nikemare:issue-585-oidc-button-moves-before-click
Oct 16, 2023
Merged

Changed input validation on login form to passive#616
nscuro merged 1 commit into
DependencyTrack:masterfrom
Nikemare:issue-585-oidc-button-moves-before-click

Conversation

@Nikemare

@Nikemare Nikemare commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

Description

Changed input validation of login form to passive. Validation will be triggered only by form submit now (click on Login button). This prevents OIDC button from moving before click event occurs.

Addressed Issue

Fixes #585

Additional Details

In BValidatedInputGroupFormInput mode of validation-provider will automatically fallback to default mode 'aggressive' if no mode is specified. Validation mode can be specified in other forms as well now.

Checklist

Fixes DependencyTrack#585

In BValidatedInputGroupFormInput mode of validation-provider will automatically fallback to default mode 'aggressive' if no mode is specified.

Signed-off-by: Nikemare <102925451+Nikemare@users.noreply.github.com>
@nscuro nscuro modified the milestone: 4.10 Oct 16, 2023

@nscuro nscuro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Nikemare! 🙌

@nscuro
nscuro merged commit 1c27f37 into DependencyTrack:master Oct 16, 2023
heyiamwahab236 pushed a commit to tecan/frontend_custom that referenced this pull request Jun 17, 2026
…utton-moves-before-click

Changed input validation on login form to passive
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OIDC Button moves before click

2 participants