fix(common): calculate percentage to tenth decimal place - #708
Merged
nscuro merged 2 commits intoJan 28, 2024
Conversation
Signed-off-by: Adam Setch <adam.setch@outlook.com>
setchy
force-pushed
the
fix/percentage-tenth-decimal
branch
from
January 28, 2024 15:47
683cfda to
3f5f955
Compare
Signed-off-by: Adam Setch <adam.setch@outlook.com>
heyiamwahab236
pushed a commit
to tecan/frontend_custom
that referenced
this pull request
Jun 17, 2026
…th-decimal fix(common): calculate percentage to tenth decimal place
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor
calcProgressPercentto found to the tenth decimal place, as per the functions comment/description.Also changed the order of the if statements to better flow.
Addressed Issue
Previous logic was rounding to the nearest integer.
Previous logic
Additional Details
Checklist