feat: add eslint and prettier - #752
Conversation
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
Great idea!
I am OK with doing it in this PR. N00b question: Is there a possibility to fail the build when files are not properly formatted? |
Perfect. I'll push the formatting updates to this PR in the morning.
Absolutely. I'll add a GitHub Action workflow to validate the formatting. Linting will need to come much later if/when the hundreds of errors are resolved. |
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
@nscuro @msymons - I have added a GitHub workflow, which for now i've set to continue-on-error. Some stats before running the automated linting fixes
After running prettier for code formatting
|
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
Signed-off-by: Adam Setch <adam.setch@outlook.com>
|
@setchy With the Codacy issue resolved, do you feel this is now ready for review? |
|
@nscuro - READY! |
…slint feat: add eslint and prettier
Description
Add eslint and prettier to help enforce consistent coding practices and formating
Addressed Issue
Additional Details
Based on feedback, I can commit the formatting changes within this PR, or a separate PR (assuming this is approved/merged).
There are 161 files with formatting updates, and 633 errors detected by eslint
Checklist