Fix link to projects in Portfolio Access Control view - #774
Merged
Conversation
Signed-off-by: Lukas Braune <lukas.braune@rohde-schwarz.com>
LaVibeX
suggested changes
Mar 13, 2024
Contributor
There was a problem hiding this comment.
To overcome the prettier issue, I suggest using this format.
@@ -124,7 +124,10 @@ export default {
}
},
projectUri: function (uuid) {
- const href = router.resolve({name: 'Project', params: {uuid: uuid}}).href;
+ const href = router.resolve({
+ name: 'Project',
+ params: { uuid: uuid },
+ }).href;
const sanitizedHref = xssFilters.uriInUnQuotedAttr(href);
return sanitizedHref;
},
Signed-off-by: Lukas Braune <lukas.braune@rohde-schwarz.com>
LaVibeX
approved these changes
Mar 13, 2024
Member
|
The joys of enforcing consistent formatting... :D You can apply the required formatting automatically by running npm run prettier-fix |
LaVibeX
suggested changes
Mar 13, 2024
LaVibeX
left a comment
Contributor
There was a problem hiding this comment.
I forgot about that, just a simple ;
Co-authored-by: Andrés Tito <52439101+LaVibeX@users.noreply.github.com> Signed-off-by: Lukas Braune <lukas.braune@rohde-schwarz.com>
LaVibeX
approved these changes
Mar 13, 2024
2 tasks
heyiamwahab236
pushed a commit
to tecan/frontend_custom
that referenced
this pull request
Jun 17, 2026
Fix link to projects in Portfolio Access Control view
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix link to projects in Portfolio Access Control view
Addressed Issue
Fixes #676
Additional Details
Checklist