Skip to content

Fix link to projects in Portfolio Access Control view - #774

Merged
nscuro merged 3 commits into
DependencyTrack:masterfrom
lukas-braune:patch-2
Mar 13, 2024
Merged

Fix link to projects in Portfolio Access Control view#774
nscuro merged 3 commits into
DependencyTrack:masterfrom
lukas-braune:patch-2

Conversation

@lukas-braune

Copy link
Copy Markdown
Contributor

Description

Fix link to projects in Portfolio Access Control view

Addressed Issue

Fixes #676

Additional Details

Checklist

Signed-off-by: Lukas Braune <lukas.braune@rohde-schwarz.com>

@LaVibeX LaVibeX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To overcome the prettier issue, I suggest using this format.

@@ -124,7 +124,10 @@ export default {
                 }
               },
               projectUri: function (uuid) {
-                const href = router.resolve({name: 'Project', params: {uuid: uuid}}).href;
+                const href = router.resolve({
+                  name: 'Project',
+                  params: { uuid: uuid },
+                }).href;
                 const sanitizedHref = xssFilters.uriInUnQuotedAttr(href);
                 return sanitizedHref;
               },

Signed-off-by: Lukas Braune <lukas.braune@rohde-schwarz.com>
Comment thread src/views/administration/accessmanagement/PortfolioAccessControl.vue Outdated
@nscuro

nscuro commented Mar 13, 2024

Copy link
Copy Markdown
Member

The joys of enforcing consistent formatting... :D

You can apply the required formatting automatically by running prettier-fix:

npm run prettier-fix

@LaVibeX LaVibeX left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I forgot about that, just a simple ;

Comment thread src/views/administration/accessmanagement/PortfolioAccessControl.vue Outdated
Co-authored-by: Andrés Tito <52439101+LaVibeX@users.noreply.github.com>
Signed-off-by: Lukas Braune <lukas.braune@rohde-schwarz.com>
@nscuro nscuro added the defect Something isn't working label Mar 13, 2024
@nscuro nscuro added this to the 4.11 milestone Mar 13, 2024

@nscuro nscuro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks both!

@nscuro
nscuro merged commit f984f88 into DependencyTrack:master Mar 13, 2024
heyiamwahab236 pushed a commit to tecan/frontend_custom that referenced this pull request Jun 17, 2026
Fix link to projects in Portfolio Access Control view
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

defect Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Malformed links to projects under Portfolio Access Control

3 participants