Skip to content

Feature: add support for serving from custom path - #801

Merged
nscuro merged 8 commits into
DependencyTrack:masterfrom
Squixx:feat/urlpath
Jul 1, 2024
Merged

Feature: add support for serving from custom path#801
nscuro merged 8 commits into
DependencyTrack:masterfrom
Squixx:feat/urlpath

Conversation

@Squixx

@Squixx Squixx commented Apr 3, 2024

Copy link
Copy Markdown

Description

I want to run dependency track frontend on a path instead of /, but doing this currently would require to do a full rebuild of the frontend. This PR could be a possible solution direction.

I've seen the reference to:

 // Relative paths cannot be supported. Research by @nscur0 - https://owasp.slack.com/archives/CTC03GX9S/p1608400149085400
  publicPath: '/',

However I can not open this link, so am oblivious to any previous research

I'll update the docs once it's clear this is the way forward

Addressed Issue

DependencyTrack/dependency-track#1514

Additional Details

setting the BASE_HREF env variable allows you to set a path

Checklist

@Squixx Squixx changed the title Feat/urlpath Feature: add suport for serving from custom path Apr 3, 2024
@Squixx Squixx changed the title Feature: add suport for serving from custom path Feature: add support for serving from custom path Apr 3, 2024
Martijn van der Meij added 4 commits April 3, 2024 16:47
Martijn van der Meij
cfeat: poc for urlpath
1fec95e 
Signed-off-by: Martijn van der Meij <martijn.vandermeij@vattenfall.nl>
Martijn van der Meij
feat: set base_href through env
7ca1a46 
Signed-off-by: Martijn van der Meij <martijn.vandermeij@vattenfall.nl>
Martijn van der Meij
feat: set base_href through env
4ba0876 
Signed-off-by: Martijn van der Meij <martijn.vandermeij@vattenfall.nl>
Martijn van der Meij
feat: update dockercompose
8f02e4c 
Signed-off-by: Martijn van der Meij <martijn.vandermeij@vattenfall.nl>
@fnxpt

fnxpt commented Apr 23, 2024

Copy link
Copy Markdown
Contributor

similar to #23

@Squixx

Squixx commented Apr 23, 2024

Copy link
Copy Markdown
Author

similar to #23

Does that work with oidc? This pr also has working oidc, but I'd be happy if either could move forward

@nscuro nscuro self-assigned this Jun 18, 2024
@nscuro nscuro added the enhancement New feature or request label Jun 18, 2024
@nscuro nscuro added this to the 4.12 milestone Jun 18, 2024
@nscuro

nscuro commented Jun 18, 2024

Copy link
Copy Markdown
Member

Sorry for the long wait @Squixx, I'll have a look at this next and have assigned it to v4.12.

nscuro
nscuro reviewed Jun 30, 2024
View reviewed changes

@nscuro nscuro left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again sorry for the delay! Overall this looks good to me.

Just a minor nitpick about naming of the env var.

Also, it would be good to add a few words about how to configure this in the docs: https://github.com/DependencyTrack/dependency-track/blob/master/docs/_docs/getting-started/configuration.md#frontend

Comment thread docker/Dockerfile.alpine Outdated
Comment thread docker/Dockerfile.alpine
Squixx and others added 2 commits July 1, 2024 09:23
@Squixx
Merge branch 'DependencyTrack:master' into feat/urlpath
56eab4b
@vandermeij-martijn
change variable name to BASE_PATH
7fb7223 
Signed-off-by: Martijn van der Meij <martijn.vandermeij@vattenfall.com>
@Squixx Squixx mentioned this pull request Jul 1, 2024
Merged
5 tasks
@Squixx

Squixx commented Jul 1, 2024

Copy link
Copy Markdown
Author

Again sorry for the delay! Overall this looks good to me.

Just a minor nitpick about naming of the env var.

Also, it would be good to add a few words about how to configure this in the docs: https://github.com/DependencyTrack/dependency-track/blob/master/docs/_docs/getting-started/configuration.md#frontend

added docs in DependencyTrack/dependency-track#3899

@nscuro
nscuro merged commit b1298a8 into DependencyTrack:master Jul 1, 2024
This was referenced Sep 22, 2024
Closed
Closed
@rissson rissson mentioned this pull request Oct 14, 2024
Merged
1 task
nscuro added a commit to DependencyTrack/hyades-frontend that referenced this pull request Dec 5, 2024
@nscuro Martijn van der Meij
Add support for serving from custom path
61bedb3 
Ports DependencyTrack/frontend#801

Co-authored-by: Martijn van der Meij <martijn.vandermeij@vattenfall.nl>
Signed-off-by: nscuro <nscuro@protonmail.com>
This was referenced Dec 5, 2024
Merged
Closed
nscuro added a commit to DependencyTrack/hyades-frontend that referenced this pull request Dec 5, 2024
@nscuro Martijn van der Meij
Add support for serving from custom path
6cbb845 
Ports DependencyTrack/frontend#801

Co-authored-by: Martijn van der Meij <martijn.vandermeij@vattenfall.nl>
Signed-off-by: nscuro <nscuro@protonmail.com>
nscuro added a commit to DependencyTrack/hyades-frontend that referenced this pull request Jan 27, 2025
@nscuro
Add support for serving from custom path
6bf0722 
Ports DependencyTrack/frontend#801

Co-authored-by: Martijn van der Meij <martijn.vandermeij@vattenfall.nl>
Signed-off-by: nscuro <nscuro@protonmail.com>

# Conflicts:
#	docker/etc/nginx/templates/default.conf.template
heyiamwahab236 pushed a commit to tecan/frontend_custom that referenced this pull request Jun 17, 2026
@nscuro
Merge pull request DependencyTrack#801 from Squixx/feat/urlpath
c58e565 
Feature: add support for serving from custom path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nscuro nscuro nscuro approved these changes

Assignees

@nscuro nscuro

Labels

enhancement New feature or request

Projects

None yet

Milestone

4.12

Development

Successfully merging this pull request may close these issues.

4 participants

@Squixx @fnxpt @nscuro @vandermeij-martijn