Skip to content

Add GCC runtime install action (12/24) - #23189

Merged
MikeMcQuaid merged 1 commit into
install-step-11-warningsfrom
install-step-12-gcc-runtime
Jul 26, 2026
Merged

Add GCC runtime install action (12/24)#23189
MikeMcQuaid merged 1 commit into
install-step-11-warningsfrom
install-step-12-gcc-runtime

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member

Eight GCC formulae share the same Linux runtime-link and specs
generation algorithm after installation.

  • probe the active GCC and glibc runtime locations
  • generate family-appropriate library, linker and header search paths
  • keep the repeated algorithm behind one literal formula step

AI disclosure: using OpenAI Codex 5.6 Sol max with local review and
testing.

@MikeMcQuaid
MikeMcQuaid force-pushed the install-step-11-warnings branch from 5b8758d to 259d082 Compare July 20, 2026 07:22
@MikeMcQuaid
MikeMcQuaid force-pushed the install-step-12-gcc-runtime branch from 4088bb9 to b221d24 Compare July 20, 2026 07:22
@MikeMcQuaid
MikeMcQuaid force-pushed the install-step-11-warnings branch from 259d082 to 7514b48 Compare July 21, 2026 07:14
@MikeMcQuaid
MikeMcQuaid force-pushed the install-step-12-gcc-runtime branch from b221d24 to a2362da Compare July 21, 2026 07:14
@MikeMcQuaid
MikeMcQuaid force-pushed the install-step-11-warnings branch 2 times, most recently from d112c5e to 46b43d5 Compare July 26, 2026 13:24
@MikeMcQuaid
MikeMcQuaid force-pushed the install-step-12-gcc-runtime branch from a2362da to 7c12c94 Compare July 26, 2026 14:12
@MikeMcQuaid
MikeMcQuaid requested a review from Copilot July 26, 2026 14:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adds a dedicated configure_gcc_runtime install-steps DSL action so GCC-family formulae on Linux can share a single post-install “runtime links + specs generation” algorithm, rather than duplicating the logic across multiple formulae.

Changes:

  • Add a new configure_gcc_runtime DSL step and runner dispatch hook in Homebrew::InstallSteps.
  • Implement the Linux GCC runtime/specs configuration logic as a Homebrew::InstallSteps::Runner private action.
  • Update RuboCop install-step allowlists, add a runner dispatch spec, and document the new action in the Formula Cookbook.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Library/Homebrew/test/rubocops/install_steps_spec.rb Updates the allowed-step list expectations to include configure_gcc_runtime.
Library/Homebrew/test/install_steps_spec.rb Adds a spec asserting the runner dispatches the new step.
Library/Homebrew/rubocops/shared/install_steps_helper.rb Allows configure_gcc_runtime in steps blocks.
Library/Homebrew/install_steps/formula_actions.rb Implements the GCC runtime configuration runner action (Linux-only).
Library/Homebrew/install_steps.rb Adds the DSL method, runner dispatch case, and requires the new action file.
docs/Formula-Cookbook.md Documents the new “repeated formula action” and when to use it.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/install_steps/formula_actions.rb Outdated
Comment thread Library/Homebrew/install_steps/formula_actions.rb
Eight GCC formulae share the same Linux runtime-link and specs
generation algorithm after installation.

- probe the active GCC and glibc runtime locations
- generate family-appropriate library, linker and header search paths
- keep the repeated algorithm behind one literal formula step
@MikeMcQuaid
MikeMcQuaid force-pushed the install-step-12-gcc-runtime branch from 7c12c94 to 6ae6def Compare July 26, 2026 14:33
@MikeMcQuaid
MikeMcQuaid marked this pull request as ready for review July 26, 2026 15:11
@MikeMcQuaid
MikeMcQuaid merged commit 07e6e44 into install-step-11-warnings Jul 26, 2026
42 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the install-step-12-gcc-runtime branch July 26, 2026 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants