Add GCC runtime install action (12/24) - #23189
Merged
MikeMcQuaid merged 1 commit intoJul 26, 2026
Merged
Conversation
MikeMcQuaid
force-pushed
the
install-step-11-warnings
branch
from
July 20, 2026 07:22
5b8758d to
259d082
Compare
MikeMcQuaid
force-pushed
the
install-step-12-gcc-runtime
branch
from
July 20, 2026 07:22
4088bb9 to
b221d24
Compare
MikeMcQuaid
force-pushed
the
install-step-11-warnings
branch
from
July 21, 2026 07:14
259d082 to
7514b48
Compare
MikeMcQuaid
force-pushed
the
install-step-12-gcc-runtime
branch
from
July 21, 2026 07:14
b221d24 to
a2362da
Compare
MikeMcQuaid
force-pushed
the
install-step-11-warnings
branch
2 times, most recently
from
July 26, 2026 13:24
d112c5e to
46b43d5
Compare
MikeMcQuaid
force-pushed
the
install-step-12-gcc-runtime
branch
from
July 26, 2026 14:12
a2362da to
7c12c94
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a dedicated configure_gcc_runtime install-steps DSL action so GCC-family formulae on Linux can share a single post-install “runtime links + specs generation” algorithm, rather than duplicating the logic across multiple formulae.
Changes:
- Add a new
configure_gcc_runtimeDSL step and runner dispatch hook inHomebrew::InstallSteps. - Implement the Linux GCC runtime/specs configuration logic as a
Homebrew::InstallSteps::Runnerprivate action. - Update RuboCop install-step allowlists, add a runner dispatch spec, and document the new action in the Formula Cookbook.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/test/rubocops/install_steps_spec.rb | Updates the allowed-step list expectations to include configure_gcc_runtime. |
| Library/Homebrew/test/install_steps_spec.rb | Adds a spec asserting the runner dispatches the new step. |
| Library/Homebrew/rubocops/shared/install_steps_helper.rb | Allows configure_gcc_runtime in steps blocks. |
| Library/Homebrew/install_steps/formula_actions.rb | Implements the GCC runtime configuration runner action (Linux-only). |
| Library/Homebrew/install_steps.rb | Adds the DSL method, runner dispatch case, and requires the new action file. |
| docs/Formula-Cookbook.md | Documents the new “repeated formula action” and when to use it. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Eight GCC formulae share the same Linux runtime-link and specs generation algorithm after installation. - probe the active GCC and glibc runtime locations - generate family-appropriate library, linker and header search paths - keep the repeated algorithm behind one literal formula step
MikeMcQuaid
force-pushed
the
install-step-12-gcc-runtime
branch
from
July 26, 2026 14:33
7c12c94 to
6ae6def
Compare
MikeMcQuaid
marked this pull request as ready for review
July 26, 2026 15:11
p-linnane
approved these changes
Jul 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Eight GCC formulae share the same Linux runtime-link and specs
generation algorithm after installation.
AI disclosure: using OpenAI Codex 5.6 Sol max with local review and
testing.