Skip to content

brew search --desc: show casks without descriptions - #23241

Merged
MikeMcQuaid merged 1 commit into
mainfrom
show-casks-without-descriptions
Jul 21, 2026
Merged

brew search --desc: show casks without descriptions#23241
MikeMcQuaid merged 1 commit into
mainfrom
show-casks-without-descriptions

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Jul 21, 2026

Copy link
Copy Markdown
Member
  • Keep cask name matches visible with the existing placeholder
  • Preserve direct brew desc output for missing descriptions
  • Handle incomplete cached cask description pairs safely

Fixes #23227


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex GPT 5.6 Sol xhigh with local review and testing.


Copilot AI review requested due to automatic review settings July 21, 2026 07:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This pull request addresses inconsistent brew search --desc results by ensuring casks that match by name are still shown even when they have no description, using a [no description] placeholder.

Changes:

  • Update Descriptions#print to print cask entries with missing descriptions using a [no description] placeholder instead of skipping them.
  • Add/adjust RSpec coverage to assert casks without descriptions are still emitted in search_descriptions output.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.

File Description
Library/Homebrew/descriptions.rb Print a placeholder for cask entries whose description is nil instead of skipping them.
Library/Homebrew/test/descriptions_spec.rb Update expectation to require printing casks with missing descriptions.
Library/Homebrew/test/search_spec.rb Add coverage for search_descriptions showing casks with no description when matched by name.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/descriptions.rb
@MikeMcQuaid
MikeMcQuaid force-pushed the show-casks-without-descriptions branch from d68b05f to 2953eaa Compare July 21, 2026 10:40
- Keep cask name matches visible with the existing placeholder
- Preserve direct `brew desc` output for missing descriptions
- Handle incomplete cached cask description pairs safely

Fixes #23227
@MikeMcQuaid
MikeMcQuaid force-pushed the show-casks-without-descriptions branch from 2953eaa to 28f65a4 Compare July 21, 2026 11:32
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Jul 21, 2026
Merged via the queue into main with commit 6203d58 Jul 21, 2026
43 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the show-casks-without-descriptions branch July 21, 2026 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Inconsistent results with brew search and brew search --desc.

4 participants