brew search --desc: show casks without descriptions - #23241
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request addresses inconsistent brew search --desc results by ensuring casks that match by name are still shown even when they have no description, using a [no description] placeholder.
Changes:
- Update
Descriptions#printto print cask entries with missing descriptions using a[no description]placeholder instead of skipping them. - Add/adjust RSpec coverage to assert casks without descriptions are still emitted in
search_descriptionsoutput.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/descriptions.rb | Print a placeholder for cask entries whose description is nil instead of skipping them. |
| Library/Homebrew/test/descriptions_spec.rb | Update expectation to require printing casks with missing descriptions. |
| Library/Homebrew/test/search_spec.rb | Add coverage for search_descriptions showing casks with no description when matched by name. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
force-pushed
the
show-casks-without-descriptions
branch
from
July 21, 2026 10:40
d68b05f to
2953eaa
Compare
- Keep cask name matches visible with the existing placeholder - Preserve direct `brew desc` output for missing descriptions - Handle incomplete cached cask description pairs safely Fixes #23227
MikeMcQuaid
force-pushed
the
show-casks-without-descriptions
branch
from
July 21, 2026 11:32
2953eaa to
28f65a4
Compare
p-linnane
approved these changes
Jul 21, 2026
krehel
approved these changes
Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew descoutput for missing descriptionsFixes #23227
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex GPT 5.6 Sol xhigh with local review and testing.