Add homepage browser check DSL - #23307
Merged
Merged
Conversation
MikeMcQuaid
marked this pull request as draft
July 26, 2026 11:03
MikeMcQuaid
force-pushed
the
homepage-verification-dsl
branch
from
July 26, 2026 11:05
3d73cff to
b99b23d
Compare
MikeMcQuaid
marked this pull request as ready for review
July 26, 2026 11:05
7 tasks
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the Formula and Cask homepage stanzas with a browsed: keyword to record when a human last verified the homepage in a browser, and uses that metadata to skip automated homepage availability audits for up to one year.
Changes:
- Add
browsed:support to Formula and CaskhomepageDSL and exposehomepage_browsedreaders. - Skip automated homepage audits when
homepage_browsedis less than one year old (Formula auditor + Cask audit). - Add/extend tests and Sorbet RBIs for the new
homepage_browsedsurface.
Reviewed changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| Library/Homebrew/formula.rb | Adds browsed: keyword handling to homepage, stores parsed date, and delegates homepage_browsed. |
| Library/Homebrew/formula_auditor.rb | Skips homepage auditing when a recent human-browsed date is present. |
| Library/Homebrew/cask/dsl.rb | Adds browsed: keyword handling to the cask homepage stanza and stores homepage_browsed. |
| Library/Homebrew/cask/audit.rb | Skips homepage HTTPS availability audit when a recent human-browsed date is present. |
| Library/Homebrew/sorbet/rbi/dsl/formula.rbi | Updates DSL RBI to include homepage_browsed. |
| Library/Homebrew/sorbet/rbi/dsl/cask/cask.rbi | Updates DSL RBI to include homepage_browsed. |
| Library/Homebrew/test/formula_spec.rb | Adds coverage for parsing/storing homepage_browsed on Formula. |
| Library/Homebrew/test/formula_auditor_spec.rb | Adds coverage for the 1-year skip vs. audit boundary in formula homepage auditing. |
| Library/Homebrew/test/cask/dsl_spec.rb | Adds coverage for parsing/storing homepage_browsed on Cask. |
| Library/Homebrew/test/cask/audit_spec.rb | Adds coverage for the 1-year skip vs. audit boundary in cask homepage auditing. |
Files not reviewed (2)
- Library/Homebrew/sorbet/rbi/dsl/cask/cask.rbi: File type not supported
- Library/Homebrew/sorbet/rbi/dsl/formula.rbi: File type not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
force-pushed
the
homepage-verification-dsl
branch
from
July 26, 2026 11:30
b99b23d to
ce5d539
Compare
- Avoid false homepage audits when sites block automated requests - Resume automated checks one year after a human browser check - Do not suppress audits for future browser-check dates - Reject browser-check metadata without a homepage URL - Document the marker in the formula and cask cookbooks
MikeMcQuaid
force-pushed
the
homepage-verification-dsl
branch
from
July 26, 2026 12:05
ce5d539 to
bff3871
Compare
Member
|
I'd say a year is a very long time for this. Maybe half a year? |
Member
Author
@SMillerDev We have >10k formulae and casks. Let's scale this down when we've got most things 🟢 most of the time before we add to the noise. |
MikeMcQuaid
enabled auto-merge
July 26, 2026 14:15
SMillerDev
approved these changes
Jul 26, 2026
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 sol xhigh with local review and testing.