Skip to content

Add homepage browser check DSL - #23307

Merged
MikeMcQuaid merged 1 commit into
mainfrom
homepage-verification-dsl
Jul 26, 2026
Merged

Add homepage browser check DSL#23307
MikeMcQuaid merged 1 commit into
mainfrom
homepage-verification-dsl

Conversation

@MikeMcQuaid

Copy link
Copy Markdown
Member
  • Avoid false homepage audits when sites block automated requests
  • Resume automated checks one year after a human browser check

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • AI was used to generate or assist with generating this PR.

OpenAI Codex 5.6 sol xhigh with local review and testing.


Copilot AI review requested due to automatic review settings July 26, 2026 11:03
@MikeMcQuaid
MikeMcQuaid marked this pull request as draft July 26, 2026 11:03
@MikeMcQuaid
MikeMcQuaid force-pushed the homepage-verification-dsl branch from 3d73cff to b99b23d Compare July 26, 2026 11:05
@MikeMcQuaid
MikeMcQuaid marked this pull request as ready for review July 26, 2026 11:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR extends the Formula and Cask homepage stanzas with a browsed: keyword to record when a human last verified the homepage in a browser, and uses that metadata to skip automated homepage availability audits for up to one year.

Changes:

  • Add browsed: support to Formula and Cask homepage DSL and expose homepage_browsed readers.
  • Skip automated homepage audits when homepage_browsed is less than one year old (Formula auditor + Cask audit).
  • Add/extend tests and Sorbet RBIs for the new homepage_browsed surface.

Reviewed changes

Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
Library/Homebrew/formula.rb Adds browsed: keyword handling to homepage, stores parsed date, and delegates homepage_browsed.
Library/Homebrew/formula_auditor.rb Skips homepage auditing when a recent human-browsed date is present.
Library/Homebrew/cask/dsl.rb Adds browsed: keyword handling to the cask homepage stanza and stores homepage_browsed.
Library/Homebrew/cask/audit.rb Skips homepage HTTPS availability audit when a recent human-browsed date is present.
Library/Homebrew/sorbet/rbi/dsl/formula.rbi Updates DSL RBI to include homepage_browsed.
Library/Homebrew/sorbet/rbi/dsl/cask/cask.rbi Updates DSL RBI to include homepage_browsed.
Library/Homebrew/test/formula_spec.rb Adds coverage for parsing/storing homepage_browsed on Formula.
Library/Homebrew/test/formula_auditor_spec.rb Adds coverage for the 1-year skip vs. audit boundary in formula homepage auditing.
Library/Homebrew/test/cask/dsl_spec.rb Adds coverage for parsing/storing homepage_browsed on Cask.
Library/Homebrew/test/cask/audit_spec.rb Adds coverage for the 1-year skip vs. audit boundary in cask homepage auditing.
Files not reviewed (2)
  • Library/Homebrew/sorbet/rbi/dsl/cask/cask.rbi: File type not supported
  • Library/Homebrew/sorbet/rbi/dsl/formula.rbi: File type not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/formula_auditor.rb Outdated
Comment thread Library/Homebrew/cask/audit.rb Outdated
Comment thread Library/Homebrew/formula.rb
Comment thread Library/Homebrew/cask/dsl.rb
@MikeMcQuaid
MikeMcQuaid force-pushed the homepage-verification-dsl branch from b99b23d to ce5d539 Compare July 26, 2026 11:30
- Avoid false homepage audits when sites block automated requests
- Resume automated checks one year after a human browser check
- Do not suppress audits for future browser-check dates
- Reject browser-check metadata without a homepage URL
- Document the marker in the formula and cask cookbooks
@MikeMcQuaid
MikeMcQuaid force-pushed the homepage-verification-dsl branch from ce5d539 to bff3871 Compare July 26, 2026 12:05
@SMillerDev

Copy link
Copy Markdown
Member

I'd say a year is a very long time for this. Maybe half a year?

@MikeMcQuaid

Copy link
Copy Markdown
Member Author

I'd say a year is a very long time for this. Maybe half a year?

@SMillerDev We have >10k formulae and casks. Let's scale this down when we've got most things 🟢 most of the time before we add to the noise.

@MikeMcQuaid
MikeMcQuaid enabled auto-merge July 26, 2026 14:15
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Jul 26, 2026
Merged via the queue into main with commit 4f912fa Jul 26, 2026
42 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the homepage-verification-dsl branch July 26, 2026 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants