Add missing on_<system> stanzas to cask stanza order

[AlternateRT]

---

• Have you followed our Contributing guidelines?
• Have you checked for other open Pull Requests for the same change?
• Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
• Have you explained why you'd like these changes included, not just what they do?
• For bug fixes, have you given step-by-step brew commands to reproduce the bug?
• Have you written new tests (excluding integration tests)? Here's an example.
• Have you successfully run brew lgtm (style, typechecking and tests) locally?

---

• AI was used to generate or assist with generating this PR.

---

Adds on_macos and on_linux to ON_SYSTEM_METHODS_STANZA_ORDER so that they also follow the pattern that was already established with older on_<system> blocks. Furthermore, this also ensures that the stanza order is enforced inside them - before this PR, this did not happen.

Adjusts the cask AST so that on_system_conditional is correctly grouped with the arch, on_arch_conditional, and os stanzas.

And finally, this re-enables the cask rubocops that were momentarily disabled to allow these migrations to occur.

[MikeMcQuaid]

Thanks @AlternateRT! Would need fixed in homebrew/cask before this can get merged.

[AlternateRT]

@MikeMcQuaid I'd be happy to fix them, though how would one go about doing that?

Without this PR, some of these orderings are currently considered style violations. Take the following generate_completions_from_executable from the 1password-cli cask.

If I attempt to fix this without this PR, wouldn't the CI on homebrew/cask fail with the following?

Taps/homebrew/homebrew-cask/Casks/1/1password-cli.rb:30:1: C: [Corrected] Cask/StanzaGrouping: stanza groups should be separated by a single empty line
  generate_completions_from_executable "op", "completion"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected

[MikeMcQuaid]

@MikeMcQuaid I'd be happy to fix them, though how would one go about doing that?

@AlternateRT open a PR in homebrew/cask with the fixes: one commit per cask changed in format <cask_token>: <summary>

If I attempt to fix this without this PR, wouldn't the CI on homebrew/cask fail with the following?

The CI on this repo should make it impossible to merge something and accidentally break homebrew/cask PR. That's why the tap_syntax job is currently failing: merging this as-is would break homebrew/cask.

If you create the proposed PR above: it should be mergeable on homebrew/cask before this PR is merged and then you can merge this.

Make sense?

Thanks for the work here!

[AlternateRT]

If you create the proposed PR above: it should be mergeable on homebrew/cask before this PR is merged and then you can merge this.

Make sense?

@MikeMcQuaid Thank you for the guidance 😄

I'll get right to it now!

[krehel]

Thanks so much for this @AlternateRT - I've had on my list to make some changes here since on_linux wasn't enforcing stanza order very well. ❤️

[AlternateRT]

Homebrew/homebrew-cask#277510

[AlternateRT]

Homebrew/homebrew-cask#277547
Homebrew/homebrew-cask#277548
Homebrew/homebrew-cask#277549

[AlternateRT]

Homebrew/homebrew-cask#277550

[AlternateRT]

If I attempt to fix this without this PR, wouldn't the CI on homebrew/cask fail with the following?

Taps/homebrew/homebrew-cask/Casks/1/1password-cli.rb:30:1: C: [Corrected] Cask/StanzaGrouping: stanza groups should be separated by a single empty line
  generate_completions_from_executable "op", "completion"
^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

1 file inspected, 1 offense detected, 1 offense corrected

As I feared, the PRs in homebrew/cask are failing because these groupings are not valid with the styling from main.

[MikeMcQuaid]

As I feared, the PRs in homebrew/cask are failing because these groupings are not valid with the styling from main.

@AlternateRT Need to figure out a way to merge one before the other then I think. It may involve something like adding but disabling by default a new or existing rule here before merge and splitting this PR into two.

[AlternateRT]

PR to group on_system_conditional after os stanza: #23339

[MikeMcQuaid]

Thanks!

[fxcoudert]

This triggered a systematic tap-syntax failure on casks: https://github.com/Homebrew/homebrew-cask/actions/runs/30438103281/job/90530829495?pr=277889

I don't know if this is a false positive of the audit, or one cask that somehow wasn't fixed prior to merging this (and if so, why it didn't trigger in CI here).

[fxcoudert]

OK it's already fixed by Homebrew/homebrew-cask@01ce7eb thanks @MikeMcQuaid

[AlternateRT]

FYI, the following PRs will result in more tap-sytax failures if they are merged as-is:

• esphome-device-builder: create cask homebrew-cask#274483
• manictime: add Linux support homebrew-cask#275281

---

Looking at the dates, it seems like this is what happened:

1. At 21:49 (GMT+2) - the day before - various: group/order missing stanzas, part 3 homebrew-cask#277548 was merged.
2. At 22:10 (GMT+2) - the day before - all the audits for this PR were successfully passed.
3. At 22:25 (GMT+2) - the day before - all the audits for affine: add Linux AppImage homebrew-cask#277513 were successfully passed before this was merged.
4. At 9:33 (GMT+2), this PR was approved and added to the merge queue.
5. At 9:42 (GMT+2), affine: add Linux AppImage homebrew-cask#277513 was approved and added to the merge queue before this was merged.
6. At 9:48 (GMT+2), affine: add Linux AppImage homebrew-cask#277513 was merged.
7. At 9:50 (GMT+2), this PR was merged.

[MikeMcQuaid]

Thanks @AlternateRT. Looks like these are now both missing required jobs so should be safe.