Skip to content

cask/audit: detect incorrect app case - #23400

Merged
MikeMcQuaid merged 1 commit into
mainfrom
detect-app-case
Aug 3, 2026
Merged

cask/audit: detect incorrect app case#23400
MikeMcQuaid merged 1 commit into
mainfrom
detect-app-case

Conversation

@krehel

@krehel krehel commented Aug 2, 2026

Copy link
Copy Markdown
Member

Occasionally we get PR's or issues in homebrew/cask due to applications not matching the right case name on case-sensitive filesystems. These are relatively rare since most users run with the standard case-insensitive, but it's still a negative user experience.

This audit is intended to catch these cases.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Opus 5 / Fable 5, validated manually and ran tests locally with brew lgtm --online


Copilot AI review requested due to automatic review settings August 2, 2026 21:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new cask audit check to detect artifact path casing mismatches between a cask’s declared artifact paths and the extracted on-disk names, helping prevent breakage on case-sensitive filesystems.

Changes:

  • Add a new audit_artifact_case audit that compares declared artifact path components to extracted path casing.
  • Add RSpec coverage for matching case, mismatched case, missing artifacts, appdir binaries, and manual installers.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Library/Homebrew/cask/audit.rb Implements the new artifact_case audit by walking extracted artifacts and comparing on-disk casing to declared paths.
Library/Homebrew/test/cask/audit_spec.rb Adds tests validating the new audit’s behavior across several artifact scenarios.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread Library/Homebrew/cask/audit.rb Outdated
Occasionally PR's or issues are opened in homebrew/cask due to
applications not matching the right case name on case-sensitive
filesystems.  These are relatively rare since most users run with the
standard case-insensitive, but it's still a negative user experience.

This audit is intended to catch these cases.

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Aug 3, 2026
Merged via the queue into main with commit 0886f47 Aug 3, 2026
43 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the detect-app-case branch August 3, 2026 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants