cask/audit: detect incorrect app case - #23400
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a new cask audit check to detect artifact path casing mismatches between a cask’s declared artifact paths and the extracted on-disk names, helping prevent breakage on case-sensitive filesystems.
Changes:
- Add a new
audit_artifact_caseaudit that compares declared artifact path components to extracted path casing. - Add RSpec coverage for matching case, mismatched case, missing artifacts, appdir binaries, and manual installers.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/cask/audit.rb | Implements the new artifact_case audit by walking extracted artifacts and comparing on-disk casing to declared paths. |
| Library/Homebrew/test/cask/audit_spec.rb | Adds tests validating the new audit’s behavior across several artifact scenarios. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Occasionally PR's or issues are opened in homebrew/cask due to applications not matching the right case name on case-sensitive filesystems. These are relatively rare since most users run with the standard case-insensitive, but it's still a negative user experience. This audit is intended to catch these cases.
bevanjkay
approved these changes
Aug 3, 2026
9 tasks
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Occasionally we get PR's or issues in homebrew/cask due to applications not matching the right case name on case-sensitive filesystems. These are relatively rare since most users run with the standard case-insensitive, but it's still a negative user experience.
This audit is intended to catch these cases.
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Opus 5 / Fable 5, validated manually and ran tests locally with
brew lgtm --online