bump: show upstream versions in release cooldown - #23409
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves brew bump output when a newer upstream release exists but is suppressed by the release-cooldown window, avoiding the misleading “is up to date!” messaging and surfacing both the suppressed upstream version and the currently bumpable version.
Changes:
- Track the newest cooldown-suppressed upstream version during livecheck and carry it through the bump flow.
- Update
brew bumpheadline/output to show “has a new version in release cooldown”, include a “Bump ready version:” line, and show the suppressed version with a recency hint. - Add/update RSpec coverage for the new behavior and the updated
livecheck_resultreturn shape.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/dev-cmd/bump.rb | Track/report cooldown-suppressed upstream versions and adjust brew bump output accordingly. |
| Library/Homebrew/test/dev-cmd/bump_spec.rb | Add tests for cooldown-suppressed output and update mocks for the new livecheck_result return value. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
MikeMcQuaid
force-pushed
the
bump-release-cooldown-output
branch
from
August 3, 2026 16:38
e282532 to
3eda9cf
Compare
p-linnane
approved these changes
Aug 3, 2026
krehel
approved these changes
Aug 3, 2026
bevanjkay
approved these changes
Aug 3, 2026
samford
approved these changes
Aug 4, 2026
samford
left a comment
samford
left a comment
Member
There was a problem hiding this comment.
Makes sense and this is more clear to me. Thanks!
- `brew bump` reported formulae as up to date when a newer upstream release was suppressed by the release cooldown, confusing upstream authors waiting for autobump. - Show the suppressed version with how recently it was released, add a `Bump-ready version:` line for what can be bumped now and change the headline from `is up to date!` to `has a new version in release cooldown`. - Fixes #23396.
MikeMcQuaid
force-pushed
the
bump-release-cooldown-output
branch
from
August 4, 2026 08:37
3eda9cf to
c596d3d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew bumpreported formulae as up to date when a newer upstream release was suppressed by the release cooldown, confusing upstream authors waiting for autobump.Bump ready version:line for what can be bumped now and change the headline fromis up to date!tohas a new version in release cooldown.Fixes #23396
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code Fable 5 high with local review and testing.