Fetch official tap HEAD for worktrees - #23472
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates Tap#install to ensure official taps created as worktrees are based on an up-to-date remote commit rather than a potentially stale local branch, while preserving the source checkout’s working state and allowing fallback to the existing HEAD when fetch isn’t possible.
Changes:
- Fetch
origin/HEADin the source tap checkout and useFETCH_HEAD’s commit when creating the detached worktree. - Add an RSpec regression test ensuring the worktree is created from the fetched remote
HEADwithout modifying the source checkout state.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/tap.rb | Fetches remote HEAD for source-tap worktree installs and uses the fetched commit for the worktree target. |
| Library/Homebrew/test/tap_spec.rb | Adds a test covering worktree creation from fetched remote HEAD while preserving source checkout state. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Avoid creating official tap worktrees from a stale local branch. - Preserve source state and offline fallback to the existing `HEAD`.
MikeMcQuaid
force-pushed
the
fresh-official-tap
branch
from
August 7, 2026 15:49
6ff91ff to
900fef4
Compare
p-linnane
approved these changes
Aug 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HEAD.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 Sol xhigh with local review and testing.