Report progress when uploading bottles - #23520
Merged
Merged
Conversation
Signed-off-by: Patrick Linnane <patrick@linnane.io>
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request adds formula-level progress output to brew pr-upload bottle uploads so long-running uploads provide visible feedback, matching the progress style used in the test-bot workflow.
Changes:
- Add per-formula progress reporting (only when uploading 3+ formulae) to the GitHub Releases and GitHub Packages upload backends.
- Add RSpec coverage for progress output presence/absence thresholds and for “skipped” (early-return) uploads still advancing progress.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| Library/Homebrew/github_releases.rb | Print progress after each formula upload when uploading 3+ formulae. |
| Library/Homebrew/github_packages.rb | Print progress after each formula upload when uploading 3+ formulae, while preserving the two-pass precheck/upload structure. |
| Library/Homebrew/test/github_releases_spec.rb | New specs asserting progress output ordering and suppression for <3 formulae. |
| Library/Homebrew/test/github_packages_spec.rb | New specs asserting progress output behavior and inclusion of skipped (early-return) cases. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew pr-uploadprints nothing between formulae, so a large bottle upload can run for many minutes with no sign of how far along it is or whether it is stuck.This adds formula-level progress to both upload backends, matching what the test jobs already print in
Library/Homebrew/test_bot/formulae.rb:It prints after each formula finishes and only when there are at least three formulae, so one and two formula uploads stay quiet. As in the test jobs, the count tracks formulae processed rather than bottles published, so a formula skipped under
--warn-on-upload-failurestill counts and itsopooline reports the skip.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?Claude Code (Opus 5) drafted the implementation and tests; I reviewed the diff, verified the new ordering tests fail when progress is printed before the upload and pass when restored, and ran
brew lgtm+ targeted specs.