Skip to content

extend/ENV/super: remove outdated cccfg flag comments - #23535

Merged
cho-m merged 1 commit into
mainfrom
remove-outdated-comments
Aug 15, 2026
Merged

extend/ENV/super: remove outdated cccfg flag comments#23535
cho-m merged 1 commit into
mainfrom
remove-outdated-comments

Conversation

@cho-m

@cho-m cho-m commented Aug 15, 2026

Copy link
Copy Markdown
Member

Minor update for outdated comment I noticed while working on some shim changes.

Removed in 20eab94


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Copilot AI lite review requested due to automatic review settings August 15, 2026 21:15

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR cleans up the HOMEBREW_CCCFG flag documentation in ENV/super by removing comment entries for flags/behavior that are no longer controlled via HOMEBREW_CCCFG, keeping the inline reference accurate for maintainers working on the compiler shim pipeline.

Changes:

  • Remove the outdated o (-oso_prefix) flag comment from the HOMEBREW_CCCFG documentation block.
  • Remove the outdated note about “These flags will also be present” and the a (apr-1-config) fix flag.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@krehel
krehel added this pull request to the merge queue Aug 15, 2026
@krehel

krehel commented Aug 15, 2026

Copy link
Copy Markdown
Member

Thanks!

@github-merge-queue
github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Aug 15, 2026
@cho-m
cho-m added this pull request to the merge queue Aug 15, 2026
Merged via the queue into main with commit 6c0fcdc Aug 15, 2026
47 checks passed
@cho-m
cho-m deleted the remove-outdated-comments branch August 15, 2026 22:42

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants