Handle disappearing Landlock paths - #23541
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request hardens Homebrew’s Linux Landlock sandbox setup against a race where “readable” filesystem paths derived during command setup may disappear before apply! runs, causing unexpected ENOENT failures.
Changes:
- Ignore
Errno::ENOENTwhile adding readable-path Landlock rules duringapply!. - Add an RSpec example covering the “path removed after command setup” race.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/extend/os/linux/sandbox/landlock.rb | Rescues Errno::ENOENT when applying readable path rules so vanished paths don’t abort sandbox setup. |
| Library/Homebrew/test/sandbox_landlock_spec.rb | Adds a test for a readable path being removed between command and apply!. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
- Ignore `ENOENT` when derived readable paths vanish during setup. - Cover the race between command setup and Landlock application.
MikeMcQuaid
force-pushed
the
landlock-readable-path-race
branch
from
August 16, 2026 18:10
708398b to
fef2da5
Compare
MikeMcQuaid
enabled auto-merge
August 16, 2026 18:11
krehel
approved these changes
Aug 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ENOENTwhen derived readable paths vanish during setup.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 Sol xhigh with local review and (unit) testing (as on macOS).