audit: resolve untapped core dependencies - #23542
Merged
Merged
Conversation
- Restore API access for external formula audits when a parent command automatically disabled it. - Preserve an explicitly disabled API setting.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts brew audit to temporarily re-enable API access when auditing external (non-core) formulae in cases where API access was automatically disabled by a parent command (e.g. when Homebrew/core is untapped), while leaving explicitly disabled API settings untouched.
Changes:
- Re-enables API access during external formula audits when
HOMEBREW_NO_INSTALL_FROM_APIwas automatically set. - Adds an RSpec example covering the automatically-disabled API scenario for external formula audits.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| Library/Homebrew/dev-cmd/audit.rb | Clears automatically-set “no API” env vars around external formula auditing so dependencies can be resolved via the API. |
| Library/Homebrew/test/dev-cmd/audit_spec.rb | Adds a regression test to ensure API access is re-enabled for external formula audits when it was automatically disabled. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
p-linnane
approved these changes
Aug 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
automatically disabled it.
Fixes #23539
brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 Sol xhigh with local review and testing.