Skip to content

audit: resolve untapped core dependencies - #23542

Merged
MikeMcQuaid merged 1 commit into
mainfrom
audit-untapped-core-dependencies
Aug 17, 2026
Merged

audit: resolve untapped core dependencies#23542
MikeMcQuaid merged 1 commit into
mainfrom
audit-untapped-core-dependencies

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Aug 16, 2026

Copy link
Copy Markdown
Member
  • Restore API access for external formula audits when a parent command
    automatically disabled it.
  • Preserve an explicitly disabled API setting.

Fixes #23539


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

OpenAI Codex 5.6 Sol xhigh with local review and testing.


- Restore API access for external formula audits when a parent command
  automatically disabled it.
- Preserve an explicitly disabled API setting.
Copilot AI lite review requested due to automatic review settings August 16, 2026 18:20

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR adjusts brew audit to temporarily re-enable API access when auditing external (non-core) formulae in cases where API access was automatically disabled by a parent command (e.g. when Homebrew/core is untapped), while leaving explicitly disabled API settings untouched.

Changes:

  • Re-enables API access during external formula audits when HOMEBREW_NO_INSTALL_FROM_API was automatically set.
  • Adds an RSpec example covering the automatically-disabled API scenario for external formula audits.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
Library/Homebrew/dev-cmd/audit.rb Clears automatically-set “no API” env vars around external formula auditing so dependencies can be resolved via the API.
Library/Homebrew/test/dev-cmd/audit_spec.rb Adds a regression test to ensure API access is re-enabled for external formula audits when it was automatically disabled.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread Library/Homebrew/test/dev-cmd/audit_spec.rb
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Aug 17, 2026
Merged via the queue into main with commit ed85520 Aug 17, 2026
49 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the audit-untapped-core-dependencies branch August 17, 2026 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

brew bump fails in tap when dependencies are unprefixed from Homebrew/core

3 participants