Skip to content

rubocops/uses_from_macos: add lldb to provided by macOS - #23563

Merged
cho-m merged 1 commit into
mainfrom
uses_from_macos-lldb
Aug 19, 2026
Merged

rubocops/uses_from_macos: add lldb to provided by macOS#23563
cho-m merged 1 commit into
mainfrom
uses_from_macos-lldb

Conversation

@cho-m

@cho-m cho-m commented Aug 19, 2026

Copy link
Copy Markdown
Member

Planning to split out LLDB in LLVM 23 so adding separate provided by macOS entry so we can annotate formula correctly (i.e. macOS has /usr/bin/lldb provided by CLT/Xcode.app).


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Copilot AI lite review requested due to automatic review settings August 19, 2026 14:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds lldb to the ProvidedByMacos::PROVIDED_BY_MACOS_FORMULAE list so formulae can be annotated as keg_only :provided_by_macos when macOS provides /usr/bin/lldb via CLT/Xcode.

Changes:

  • Add lldb to the PROVIDED_BY_MACOS_FORMULAE allowlist used by the FormulaAudit/ProvidedByMacos RuboCop cop.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread Library/Homebrew/rubocops/uses_from_macos.rb
@cho-m
cho-m added this pull request to the merge queue Aug 19, 2026
Merged via the queue into main with commit dafa973 Aug 19, 2026
48 checks passed
@cho-m
cho-m deleted the uses_from_macos-lldb branch August 19, 2026 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants