rubocops/uses_from_macos: add lldb to provided by macOS - #23563
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds lldb to the ProvidedByMacos::PROVIDED_BY_MACOS_FORMULAE list so formulae can be annotated as keg_only :provided_by_macos when macOS provides /usr/bin/lldb via CLT/Xcode.
Changes:
- Add
lldbto thePROVIDED_BY_MACOS_FORMULAEallowlist used by theFormulaAudit/ProvidedByMacosRuboCop cop.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
p-linnane
approved these changes
Aug 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Planning to split out LLDB in LLVM 23 so adding separate provided by macOS entry so we can annotate formula correctly (i.e. macOS has
/usr/bin/lldbprovided by CLT/Xcode.app).brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?