Skip to content

sorbet: Bump more RuboCop tests to higher typed levels - #23578

Merged
MikeMcQuaid merged 1 commit into
sorbet-core-two-errorsfrom
sorbet-rubocop-two-errors
Aug 20, 2026
Merged

sorbet: Bump more RuboCop tests to higher typed levels#23578
MikeMcQuaid merged 1 commit into
sorbet-core-two-errorsfrom
sorbet-rubocop-two-errors

Conversation

@issyl0

@issyl0 issyl0 commented Aug 19, 2026

Copy link
Copy Markdown
Member

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include Hyperfine benchmarks.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Claude Code CLI, Claude Opus 5 (High reasoning, Ultracode was too intense 🤯), with human prompting, review and tweaks.


  • Part of my ongoing quest to bump all the test files to at least Sorbet typed: true, because that's a thing we can do.
  • In a 🥞 gh stack because I wanted to try them out on a real chain of changes.
  • See the commit message body for the full description of the changes.

@issyl0
issyl0 force-pushed the sorbet-rubocop-two-errors branch from f466ceb to 54a1523 Compare August 19, 2026 21:44
@issyl0
issyl0 force-pushed the sorbet-rubocop-two-errors branch from 54a1523 to 51bb6f8 Compare August 19, 2026 21:45
@issyl0
issyl0 marked this pull request as ready for review August 19, 2026 22:17
Copilot AI lite review requested due to automatic review settings August 19, 2026 22:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR increases Sorbet type-checking strictness for a RuboCop cop spec by bumping the file to # typed: true, with a small spec refactor to keep the example self-contained.

Changes:

  • Bump Library/Homebrew/test/rubocops/urls_spec.rb from typed: false to typed: true.
  • Replace a let(:expected_url) with a local expected_url inside the example.
Show a summary per file
File Description
Library/Homebrew/test/rubocops/urls_spec.rb Raises Sorbet typing level for the URLs cop spec and adjusts a variable definition to suit the stricter typing context.

Review details

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

  • Files reviewed: 1/1 changed files
  • Comments generated: 0
  • Review effort level: Lite

- Define the expected Apache URL inside the shared example so both Sorbet and RSpec resolve it in example scope.
@issyl0
issyl0 force-pushed the sorbet-rubocop-two-errors branch from 51bb6f8 to d60d11a Compare August 19, 2026 23:29
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Aug 20, 2026
Merged via the queue into main with commit 5c021ad Aug 20, 2026
61 of 73 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the sorbet-rubocop-two-errors branch August 20, 2026 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants