Skip to content

Add TODO for Cargo release cooldown - #23627

Merged
MikeMcQuaid merged 1 commit into
mainfrom
cargo-min-publish-age
Aug 23, 2026
Merged

Add TODO for Cargo release cooldown#23627
MikeMcQuaid merged 1 commit into
mainfrom
cargo-min-publish-age

Conversation

@MikeMcQuaid

@MikeMcQuaid MikeMcQuaid commented Aug 23, 2026

Copy link
Copy Markdown
Member

Add a TODO comment to enable this later.


  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

OpenAI Codex Sol 5.6 xhigh with local review and testing.


Copilot AI lite review requested due to automatic review settings August 23, 2026 09:27

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds Cargo crates.io release cooldown settings and Cargo resolver configuration to formula sandboxes.

Changes:

  • Configures Cargo minimum publish age and unstable resolver settings.
  • Adds unit coverage for the sandbox environment variables.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Summary
Library/Homebrew/test/formula_spec.rb Tests the new Cargo settings.
Library/Homebrew/formula.rb Configures Cargo cooldown environment variables.

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

@MikeMcQuaid
MikeMcQuaid enabled auto-merge August 23, 2026 12:03
Comment thread Library/Homebrew/formula.rb Outdated
- Record Cargo 1.100's expected stable release date
- Keep unstable Cargo and Rust settings disabled until then
@MikeMcQuaid
MikeMcQuaid force-pushed the cargo-min-publish-age branch from 8de664a to 27cc83b Compare August 23, 2026 16:58
@MikeMcQuaid MikeMcQuaid changed the title Add Cargo release cooldown Add TODO for Cargo release cooldown Aug 23, 2026
@MikeMcQuaid
MikeMcQuaid requested a review from carlocab August 23, 2026 16:59
@MikeMcQuaid
MikeMcQuaid added this pull request to the merge queue Aug 23, 2026
Merged via the queue into main with commit 1466820 Aug 23, 2026
47 checks passed
@MikeMcQuaid
MikeMcQuaid deleted the cargo-min-publish-age branch August 23, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants