Make network access allowances exclusive - #23635
Merged
Merged
Conversation
krehel
approved these changes
Aug 23, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Formula network-access DSL so explicit phases act as an exclusive allow-list while preserving existing inputs.
Changes:
- Denies unspecified phases.
- Adds coverage for selective and array-based allowances.
- Documents the updated behavior.
- Identified a moderate issue: invalid phases can mutate policy state before raising (3 votes).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Summary |
|---|---|
Library/Homebrew/test/formula_spec.rb |
Tests exclusive phase allowances. |
Library/Homebrew/formula.rb |
Implements the updated policy behavior; validation should occur before mutation. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
MikeMcQuaid
disabled auto-merge
August 23, 2026 20:09
- Treat explicit phases as an allow-list so formulae can name only the phases requiring network access. - Validate every phase before changing the network access policy. - Preserve no-argument behaviour and scalar or array inputs.
MikeMcQuaid
force-pushed
the
network-access-allow-list
branch
from
August 23, 2026 20:11
36cacc5 to
92a900c
Compare
MikeMcQuaid
enabled auto-merge
August 23, 2026 20:11
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 23, 2026
github-merge-queue
Bot
removed this pull request from the merge queue due to failed status checks
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 sol high with local review and testing.