Avoid eager PatchELF signature evaluation - #23636
Merged
Merged
Conversation
- Keep `PatchELF` lazy while allowing patch-first calls - Cover patching before metadata loads the dependency
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a flaky Linux ELF patching scenario by preventing Sorbet runtime signature evaluation from eagerly resolving PatchELF before patchelf is required, and adds coverage for calling patch! before any metadata access.
Changes:
- Switch
patchelf_patchertoT::Sig::WithoutRuntime.sigto avoid eager::PatchELFconstant resolution during file load. - Add a Linux spec case intended to cover patching-before-metadata behavior.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| Library/Homebrew/os/linux/elf.rb | Avoids eager PatchELF constant resolution by using T::Sig::WithoutRuntime.sig for patchelf_patcher. |
| Library/Homebrew/test/os/linux/pathname_spec.rb | Adds a new example around calling patch! without first reading ELF metadata. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Signed-off-by: Patrick Linnane <patrick@linnane.io>
p-linnane
approved these changes
Aug 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a flaky test.
PatchELFlazy while allowing patch-first callsbrew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?OpenAI Codex 5.6 high with local review and testing.