formula_creator: add deny network for go and rust - #23734
Merged
Conversation
These require fetch step to download dependencies.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds offline Go and Rust formula templates using Homebrew’s separate dependency-fetch phase.
Changes:
- Generates
fetchmethods for Go and Rust dependencies. - Denies build-time network access and enables Cargo offline installation.
- Adds template-generation coverage.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
Library/Homebrew/formula_creator.rb |
Generates offline Go and Rust build templates. |
Library/Homebrew/test/formula_creator_spec.rb |
Verifies generated fetch and network settings. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
carlocab
approved these changes
Sep 1, 2026
Member
|
Thanks @cho-m! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Create Go and Rust-based formulae with
deny_network_access!. These account for majority of newly added formulae.These require a separate fetch step.
For Rust, it matches our existing documentation. Testing functionality in Homebrew/homebrew-core#300798
For Go, it uses
go mod downloadto fetch into cache that we defined. Testing functionality in Homebrew/homebrew-core#301819For remaining:
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?