formula_creator: remove outdated comment, show resource only for perl - #23745
Conversation
Since we no longer officially support running test on HEAD, remove the extra comment about it. Also only show resource block on Perl where the install has a matching stage block. We switched to recommending Bundler on Ruby.
There was a problem hiding this comment.
🟡 Changes recommended
The Ruby resource-exclusion behavior needs regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Updates generated formula templates to reflect current Ruby and test guidance.
Changes:
- Limits dependency resource examples to Perl formulas.
- Removes outdated
--HEADtest instructions.
File summaries
| File | Description |
|---|---|
Library/Homebrew/formula_creator.rb |
Updates generated formula comments and resource guidance. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
|
Will merge and continue work on Ruby part. Once I have a working example in Homebrew/core, I will open follow up PR. Moving thread discussion response for visibility:
I did try some other configs and so far only From documentation, Bundler 5 will change
Footnotes |
Since we no longer officially support running test on HEAD, remove the extra comment about it.
Also only show resource block on Perl where the install has a matching stage block. We switched to recommending Bundler on Ruby.
As note, Perl still needs manual resource handling. There isn't a great way to handle "macOS perl" dependencies vs "brew perl" dependencies.
We could use "brew perl" to specify dependencies and then
brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?