Skip to content

formula_creator: remove outdated comment, show resource only for perl - #23745

Merged
cho-m merged 1 commit into
mainfrom
formula_creator-updates
Sep 3, 2026
Merged

formula_creator: remove outdated comment, show resource only for perl#23745
cho-m merged 1 commit into
mainfrom
formula_creator-updates

Conversation

@cho-m

@cho-m cho-m commented Sep 2, 2026

Copy link
Copy Markdown
Member

Since we no longer officially support running test on HEAD, remove the extra comment about it.

Also only show resource block on Perl where the install has a matching stage block. We switched to recommending Bundler on Ruby.


As note, Perl still needs manual resource handling. There isn't a great way to handle "macOS perl" dependencies vs "brew perl" dependencies.

We could use "brew perl" to specify dependencies and then

  • filter out the ones already installed as part of Apple system perl.
  • or just install duplicates. Main advantage of deduping is disk space usage.

  • Have you followed our Contributing guidelines?
  • Have you checked for other open Pull Requests for the same change?
  • Have you explained what your changes do? Performance claims (e.g. "this is faster") must include brew benchmark results.
  • Have you explained why you'd like these changes included, not just what they do?
  • For bug fixes, have you given step-by-step brew commands to reproduce the bug?
  • Have you written new tests (excluding integration tests)? Here's an example.
  • Have you successfully run brew lgtm (style, typechecking and tests) locally?

  • I did not use AI/LLM to create this PR, or I disclosed the tool/model below and reviewed its output; I did not attribute commits to AI and will answer maintainer questions and review comments myself without AI/LLM.

Since we no longer officially support running test on HEAD, remove the
extra comment about it.

Also only show resource block on Perl where the install has a matching
stage block. We switched to recommending Bundler on Ruby.
Copilot AI balanced review requested due to automatic review settings September 2, 2026 14:28

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The Ruby resource-exclusion behavior needs regression coverage.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

Updates generated formula templates to reflect current Ruby and test guidance.

Changes:

  • Limits dependency resource examples to Perl formulas.
  • Removes outdated --HEAD test instructions.
File summaries
File Description
Library/Homebrew/formula_creator.rb Updates generated formula comments and resource guidance.
Review details
  • Files reviewed: 1/1 changed files
  • Comments generated: 1
  • Review effort level: Balanced

💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.

Comment thread Library/Homebrew/formula_creator.rb

@MikeMcQuaid MikeMcQuaid left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@cho-m

cho-m commented Sep 3, 2026

Copy link
Copy Markdown
Member Author

Will merge and continue work on Ruby part. Once I have a working example in Homebrew/core, I will open follow up PR.


Moving thread discussion response for visibility:

--no-binstubs or setting the config variable might work here. temporary GEM_HOME makes sense to me too 👍🏻

I did try some other configs and so far only GEM_HOME and BUNDLE_PATH worked.

From documentation, Bundler 5 will change BUNDLE_PATH default so may go with setting the new path

  • "When not set, Bundler install by default to a .bundle directory relative to repository root in Bundler 5, and to the default system path (Gem.dir) before Bundler 5"1

Footnotes

  1. https://guides.rubygems.org/command-reference/bundle-config/#:~:text=path%20(-,BUNDLE_PATH,-)%3A%20The%20location%20on

@cho-m
cho-m added this pull request to the merge queue Sep 3, 2026
Merged via the queue into main with commit 400db3d Sep 3, 2026
59 checks passed
@cho-m
cho-m deleted the formula_creator-updates branch September 3, 2026 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants