generate-cask-ci-matrix: drop macOS Intel CI - #23757
Merged
Merged
Conversation
9 tasks
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The empty-runner path can incorrectly audit the whole tap and needs regression coverage.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Removes macOS Intel and simulated-architecture cask CI while retaining ARM macOS and Linux x86_64 coverage.
Changes:
- Removes Intel macOS runners and cross-architecture jobs.
- Warns when changed casks have no compatible runner.
- Updates runner-selection tests.
File summaries
| File | Review |
|---|---|
Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb |
Moderate (1 vote): Empty cask jobs can incorrectly trigger whole-tap ARM audits; track selected casks separately. Nit (1 vote): Add coverage verifying the empty matrix and warning for Intel-only casks. |
Library/Homebrew/test/dev-cmd/generate-cask-ci-matrix_spec.rb |
Updates runner expectations, but lacks coverage for the Intel-only empty-runner path. |
Review details
Suppressed comments (1)
Library/Homebrew/dev-cmd/generate-cask-ci-matrix.rb:277
- The warning is the only visibility safeguard for casks that now receive zero test jobs, but no test exercises it: the new specs only call
filter_runners/runners, while the integration case uses a supported cask. Please add agenerate_matrixexample for an Intel-only macOS cask that verifies the empty matrix and this annotation, so a future output or control-flow regression cannot silently leave the cask untested.
puts "::warning file=#{path}::No CI runner supports this cask, so it will not be tested." if runners.empty?
- Files reviewed: 2/2 changed files
- Comments generated: 1
- Review effort level: Balanced
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
MikeMcQuaid
reviewed
Sep 3, 2026
MikeMcQuaid
left a comment
Member
There was a problem hiding this comment.
Thanks! Want to 🔥 macOS Intel, but keep Linux Intel.
krehel
approved these changes
Sep 3, 2026
Member
|
Thanks for this. Agree the Intel runners are getting worse and ready to 💥 them away. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the
macos-15-intelrunner and the simulated-architecture jobs that ranauditandfetchwith--arch=intelon ARM runners, matching the macOS Intel CI removal in Homebrew/brew and Homebrew/homebrew-core. Linux x86_64 is still tested onubuntu-latest.Caveats;
::warningannotation is emitted when a changed cask has no runner so this is visible on the pull request.brew benchmarkresults.brewcommands to reproduce the bug?brew lgtm(style, typechecking and tests) locally?I used
claude-codewith Fable 5.1 to help generate the extended changes.