Skip to content

Fix bug in optimization_problem_solution_t::copy_from - #109

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-25.08from
rg20:issue_108
Jun 18, 2025
Merged

Fix bug in optimization_problem_solution_t::copy_from#109
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-25.08from
rg20:issue_108

Conversation

@rg20

@rg20 rg20 commented Jun 17, 2025

Copy link
Copy Markdown
Contributor

This PR closes #108

When PDLP fails, the vectors are not resized appropriately. This is causing wrong values sent to julia interface. This could result in crashes for large cases.

@rg20
rg20 requested a review from a team as a code owner June 17, 2025 20:00
@rg20
rg20 requested review from hlinsen and kaatish June 17, 2025 20:00
@copy-pr-bot

copy-pr-bot Bot commented Jun 17, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rg20 rg20 added this to the 25.08 milestone Jun 17, 2025
@rg20

rg20 commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Jun 17, 2025

Copy link
Copy Markdown

/ok to test

@rg20, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@rg20

rg20 commented Jun 17, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 9b3b9cd

@rg20 rg20 added bug Something isn't working pdlp non-breaking Introduces a non-breaking change labels Jun 17, 2025

@Kh4ster Kh4ster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, nice catch!

@rg20

rg20 commented Jun 18, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 067c4c2 into NVIDIA:branch-25.08 Jun 18, 2025
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
This PR closes NVIDIA#108 

When PDLP fails, the vectors are not resized appropriately.  This is causing wrong values sent to julia interface.  This could result in crashes for large cases.

Authors:
  - Rajesh Gandham (https://github.com/rg20)

Approvers:
  - Nicolas Blin (https://github.com/Kh4ster)

URL: NVIDIA#109
@rg20
rg20 deleted the issue_108 branch August 19, 2026 21:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change pdlp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Output primal solution is wrong when pdlp fails but dual simplex works

3 participants