Skip to content

Update build and test skills - #1127

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
mlubin:skills
Apr 21, 2026
Merged

Update build and test skills#1127
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
mlubin:skills

Conversation

@mlubin

@mlubin mlubin commented Apr 21, 2026

Copy link
Copy Markdown
Contributor

Both skills address issues that agents got tripped up on. I tested that they fixed the issues. (Skills authored by Claude.)

@mlubin
mlubin requested a review from a team as a code owner April 21, 2026 02:10
@mlubin
mlubin requested a review from Iroy30 April 21, 2026 02:10
@copy-pr-bot

copy-pr-bot Bot commented Apr 21, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mlubin mlubin added non-breaking Introduces a non-breaking change Agentic This label is used to track agentic and skill related issues labels Apr 21, 2026
@mlubin

mlubin commented Apr 21, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test fbbfb1e

@coderabbitai

coderabbitai Bot commented Apr 21, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

Added documentation to two skill files instructing developers on test dataset downloads and CUDA toolkit compatibility validation before building and testing cuOpt. Changes cover dataset prerequisites, failure modes, and compatibility checks between CUDA versions and GPU drivers.

Changes

Cohort / File(s) Summary
Documentation: Dataset Prerequisites
skills/cuopt-developer/SKILL.md
Added guidance on downloading required MPS/data test files before running C++ or Python tests, including characteristic failure modes and remediation steps referencing CONTRIBUTING.md.
Documentation: CUDA Compatibility
skills/cuopt-installation-developer/SKILL.md
Added instructions to validate CUDA toolkit vs GPU driver compatibility, specifying environment selection criteria, clean rebuild procedures for version mismatches, and documented runtime failure examples.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~12 minutes

🚥 Pre-merge checks | ✅ 3
✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Update build and test skills' is related to the changeset, which adds documentation to two skill files addressing build and test issues.
Description check ✅ Passed The description is related to the changeset, mentioning that skills address issues agents encountered and were tested to fix those issues.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands and usage tips.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.

Inline comments:
In `@skills/cuopt-installation-developer/SKILL.md`:
- Around line 34-36: The fenced code block that contains the error message "RMM
failure ... cudaMallocAsync not supported with this CUDA driver/runtime version"
should include a language identifier for proper rendering; update the
triple-backtick fence that surrounds that message to use a language tag (e.g.,
```text) so the block becomes ```text ... ``` and ensure only the fence is
changed (leave the message text unchanged).
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4b54835c-c38d-4a73-89a6-63af8df28999

📥 Commits

Reviewing files that changed from the base of the PR and between 8ac222d and fbbfb1e.

📒 Files selected for processing (2)
  • skills/cuopt-developer/SKILL.md
  • skills/cuopt-installation-developer/SKILL.md

Comment on lines +34 to +36
```
RMM failure ... cudaMallocAsync not supported with this CUDA driver/runtime version
```

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue | 🟡 Minor

Specify language for the code block.

The fenced code block showing the error message should have a language identifier for consistent rendering. As per static analysis tools, fenced code blocks should specify a language.

📝 Proposed fix
-```
+```text
 RMM failure ... cudaMallocAsync not supported with this CUDA driver/runtime version
</details>

<details>
<summary>🧰 Tools</summary>

<details>
<summary>🪛 markdownlint-cli2 (0.22.0)</summary>

[warning] 34-34: Fenced code blocks should have a language specified

(MD040, fenced-code-language)

</details>

</details>

<details>
<summary>🤖 Prompt for AI Agents</summary>

Verify each finding against the current code and only fix it if needed.

In @skills/cuopt-installation-developer/SKILL.md around lines 34 - 36, The
fenced code block that contains the error message "RMM failure ...
cudaMallocAsync not supported with this CUDA driver/runtime version" should
include a language identifier for proper rendering; update the triple-backtick
fence that surrounds that message to use a language tag (e.g., text) so the block becomes text ... ``` and ensure only the fence is changed (leave the
message text unchanged).


</details>

<!-- fingerprinting:phantom:triton:puma:83914d3b-0c8b-4212-9b32-2fb0d430fd51 -->

<!-- This is an auto-generated comment by CodeRabbit -->

@mlubin
mlubin requested a review from ramakrishnap-nv April 21, 2026 13:38
@ramakrishnap-nv ramakrishnap-nv added the improvement Improves an existing functionality label Apr 21, 2026
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

/merge

@rapids-bot
rapids-bot Bot merged commit 27b13d7 into NVIDIA:main Apr 21, 2026
46 checks passed
@mlubin
mlubin deleted the skills branch April 21, 2026 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Agentic This label is used to track agentic and skill related issues improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants