Update build and test skills - #1127
Conversation
|
/ok to test fbbfb1e |
📝 WalkthroughWalkthroughAdded documentation to two skill files instructing developers on test dataset downloads and CUDA toolkit compatibility validation before building and testing cuOpt. Changes cover dataset prerequisites, failure modes, and compatibility checks between CUDA versions and GPU drivers. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@skills/cuopt-installation-developer/SKILL.md`:
- Around line 34-36: The fenced code block that contains the error message "RMM
failure ... cudaMallocAsync not supported with this CUDA driver/runtime version"
should include a language identifier for proper rendering; update the
triple-backtick fence that surrounds that message to use a language tag (e.g.,
```text) so the block becomes ```text ... ``` and ensure only the fence is
changed (leave the message text unchanged).
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 4b54835c-c38d-4a73-89a6-63af8df28999
📒 Files selected for processing (2)
skills/cuopt-developer/SKILL.mdskills/cuopt-installation-developer/SKILL.md
| ``` | ||
| RMM failure ... cudaMallocAsync not supported with this CUDA driver/runtime version | ||
| ``` |
There was a problem hiding this comment.
Specify language for the code block.
The fenced code block showing the error message should have a language identifier for consistent rendering. As per static analysis tools, fenced code blocks should specify a language.
📝 Proposed fix
-```
+```text
RMM failure ... cudaMallocAsync not supported with this CUDA driver/runtime version</details>
<details>
<summary>🧰 Tools</summary>
<details>
<summary>🪛 markdownlint-cli2 (0.22.0)</summary>
[warning] 34-34: Fenced code blocks should have a language specified
(MD040, fenced-code-language)
</details>
</details>
<details>
<summary>🤖 Prompt for AI Agents</summary>
Verify each finding against the current code and only fix it if needed.
In @skills/cuopt-installation-developer/SKILL.md around lines 34 - 36, The
fenced code block that contains the error message "RMM failure ...
cudaMallocAsync not supported with this CUDA driver/runtime version" should
include a language identifier for proper rendering; update the triple-backtick
fence that surrounds that message to use a language tag (e.g., text) so the block becomes text ... ``` and ensure only the fence is changed (leave the
message text unchanged).
</details>
<!-- fingerprinting:phantom:triton:puma:83914d3b-0c8b-4212-9b32-2fb0d430fd51 -->
<!-- This is an auto-generated comment by CodeRabbit -->
|
/merge |
Both skills address issues that agents got tripped up on. I tested that they fixed the issues. (Skills authored by Claude.)