Skip to content

Fix broken sample.mps download link in server LP examples docs - #1358

Merged
ramakrishnap-nv merged 2 commits into
release/26.06from
fix/lp-examples-broken-mps-link
Jun 2, 2026
Merged

Fix broken sample.mps download link in server LP examples docs#1358
ramakrishnap-nv merged 2 commits into
release/26.06from
fix/lp-examples-broken-mps-link

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

Description

The :download: link for sample.mps in cuopt-server/examples/lp-examples.rst
pointed at an external host (people.math.sc.edu) that is unreachable, breaking
the docs linkcheck build:

cuopt-server/examples/lp-examples.rst:439: [broken]
https://people.math.sc.edu/Burkardt/datasets/mps/testprob.mps

The same sample.mps already exists in the repo at
cuopt-server/examples/lp/examples/sample.mps and is shown via literalinclude
on the next line, so the download now points at that local file.

Issue

Docs linkcheck failure (external host down).

Checklist

  • Testing
    • NA (docs-only; make linkcheck no longer reports this URL)
  • Documentation
    • NA

The :download: target pointed at an external host (people.math.sc.edu) that is
unreachable, breaking the docs linkcheck. The same sample.mps already exists in
the repo and is shown via literalinclude on the next line, so point the download
at the local file (lp/examples/sample.mps).

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@copy-pr-bot

copy-pr-bot Bot commented Jun 1, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review June 1, 2026 20:33
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner June 1, 2026 20:33
@ramakrishnap-nv
ramakrishnap-nv requested a review from tmckayus June 1, 2026 20:33
@coderabbitai

coderabbitai Bot commented Jun 1, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: 361af442-f166-4023-8cf2-c112a7828e75

📥 Commits

Reviewing files that changed from the base of the PR and between 205bf80 and b477616.

📒 Files selected for processing (1)
  • ci/utils/install_cudss.sh

📝 Walkthrough

Walkthrough

Updates: LP CLI docs now reference a local sample MPS asset; CI helper script pins cuDSS packages to version 0.7.* and adds SPDX headers.

Changes

Documentation Update

Layer / File(s) Summary
Sample MPS download link reference
docs/cuopt/source/cuopt-server/examples/lp-examples.rst
The "A sample MPS file" download directive now points to local file lp/examples/sample.mps instead of an external URL.

CI cuDSS Installation

Layer / File(s) Summary
Pin cuDSS packages and add SPDX headers
ci/utils/install_cudss.sh
install_cudss.sh now includes SPDX headers and installs cuDSS packages pinned to 0.7.* for both RPM (dnf wildcard -cuda-<ver>-0.7.*) and DEB (apt-get libcudss-devel=0.7.*) flows.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly summarizes the main change: fixing a broken sample.mps download link in server LP examples documentation.
Description check ✅ Passed The description is directly related to the changeset, explaining the broken external link issue and how it's being fixed by pointing to a local file.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/lp-examples-broken-mps-link

Comment @coderabbitai help to get the list of available commands and usage tips.

@ramakrishnap-nv ramakrishnap-nv self-assigned this Jun 1, 2026
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality bug Something isn't working and removed improvement Improves an existing functionality labels Jun 1, 2026
The dnf 'cuda' repo now serves cuDSS 0.8, but this branch's
sparse_cholesky.cuh still uses the 0.7 reordering API
(cudssAlgType_t / CUDSS_ALG_3), which fails to compile against 0.8
headers. Pin the install to 0.7.x; bump once 0.8 is on PyPI/conda-forge.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner June 1, 2026 21:30
@ramakrishnap-nv
ramakrishnap-nv requested a review from msarahan June 1, 2026 21:30
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/merge

@ramakrishnap-nv
ramakrishnap-nv merged commit f7c8bd8 into release/26.06 Jun 2, 2026
187 of 192 checks passed
@ramakrishnap-nv
ramakrishnap-nv deleted the fix/lp-examples-broken-mps-link branch July 9, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants