Fix broken sample.mps download link in server LP examples docs - #1358
Merged
Conversation
The :download: target pointed at an external host (people.math.sc.edu) that is unreachable, breaking the docs linkcheck. The same sample.mps already exists in the repo and is shown via literalinclude on the next line, so point the download at the local file (lp/examples/sample.mps). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughUpdates: LP CLI docs now reference a local sample MPS asset; CI helper script pins cuDSS packages to version 0.7.* and adds SPDX headers. ChangesDocumentation Update
CI cuDSS Installation
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
tmckayus
approved these changes
Jun 1, 2026
tmckayus
approved these changes
Jun 1, 2026
The dnf 'cuda' repo now serves cuDSS 0.8, but this branch's sparse_cholesky.cuh still uses the 0.7 reordering API (cudssAlgType_t / CUDSS_ALG_3), which fails to compile against 0.8 headers. Pin the install to 0.7.x; bump once 0.8 is on PyPI/conda-forge. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
:download:link forsample.mpsincuopt-server/examples/lp-examples.rstpointed at an external host (
people.math.sc.edu) that is unreachable, breakingthe docs
linkcheckbuild:The same
sample.mpsalready exists in the repo atcuopt-server/examples/lp/examples/sample.mpsand is shown vialiteralincludeon the next line, so the download now points at that local file.
Issue
Docs
linkcheckfailure (external host down).Checklist
make linkcheckno longer reports this URL)