Ceil cuDSS to >=0.7,<0.8 - #1371
Merged
Merged
Conversation
Constrain cuDSS to the 0.7 series across the build and runtime dependency declarations. Moves the version window down from 0.8: dependencies.yaml (conda libcudss-dev, pip cu12/cu13) with regenerated conda environments and pyproject.toml, the libcuopt conda recipe, FindCUDSS.cmake (find_package 0.8 -> 0.7), and the wheel-build install_cudss.sh pin. The barrier sparse Cholesky code is unaffected: its 0.8-only calls are guarded by CUDSS_VERSION_MINOR >= 8 with 0.7 fallbacks, so it compiles cleanly against 0.7. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ramakrishnap-nv
marked this pull request as ready for review
June 2, 2026 21:42
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR lowers cuDSS version bounds from 0.8.x to 0.7.x across dependency manifests, conda environments and recipes, CMake discovery, CI install script, and Python packaging metadata. ChangescuDSS Version Downgrade
Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Possibly related PRs
Suggested reviewers
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
bdice
approved these changes
Jun 2, 2026
The libcuopt conda recipe listed `libcudss` as a bare run dependency and ignored its run-export, so the host pin (libcudss-dev >=0.7,<0.8) constrained only the build. The conda-python-tests environment, which does not include the `cuda` dependency group, then resolved libcudss to the newest channel build (0.8) transitively via libcuopt, breaking against the 0.7-built binary. Pin the run dep so the ceiling propagates. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
Iroy30
approved these changes
Jun 2, 2026
Collaborator
Author
|
/merge |
ramakrishnap-nv
added a commit
that referenced
this pull request
Jun 3, 2026
My previous commit changed it to 2025 via a verify-copyright misfire in a detached-HEAD worktree (no resolvable target branch). The file is modified in this branch (and in 2026 via #1365/#1371), so 2025-2026 is correct; restore it. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cudss 0.8 had some speed-up regressions, so switching back to 0.7