Skip to content

fix(routing): lower opt level for sliding_window.cu to avoid nvcc 13.0.3 ICE - #1452

Merged
rapids-bot[bot] merged 1 commit into
mainfrom
fix/sliding-window-nvcc-ice
Jun 24, 2026
Merged

fix(routing): lower opt level for sliding_window.cu to avoid nvcc 13.0.3 ICE#1452
rapids-bot[bot] merged 1 commit into
mainfrom
fix/sliding-window-nvcc-ice

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

nvcc 13.0.3 on x86_64 segfaults (signal 11) at -O3 compiling sliding_window.cu — the ICE is triggered by the recursive if constexpr template (permutation_cases). Dropping this file to -O2 via set_source_files_properties sidesteps the bug with no runtime impact.

@copy-pr-bot

copy-pr-bot Bot commented Jun 23, 2026

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ramakrishnap-nv ramakrishnap-nv self-assigned this Jun 23, 2026
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality bug Something isn't working and removed improvement Improves an existing functionality labels Jun 23, 2026
@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review June 23, 2026 20:20
@ramakrishnap-nv
ramakrishnap-nv requested review from a team as code owners June 23, 2026 20:20
@coderabbitai

coderabbitai Bot commented Jun 23, 2026

Copy link
Copy Markdown

Review Change Stack

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: db8f82e6-f0b6-4122-af0c-1ab13be9e3f3

📥 Commits

Reviewing files that changed from the base of the PR and between 7c8e585 and 71e7334.

📒 Files selected for processing (1)
  • cpp/CMakeLists.txt

📝 Walkthrough

Walkthrough

Adds a set_source_files_properties call in cpp/CMakeLists.txt that overrides the compilation options for src/routing/local_search/sliding_window.cu to --split-compile=0. This per-file NVCC option is positioned before the existing conditional per-source option logic for HOST_LINEINFO and DEFINE_ASSERT-driven settings.

Changes

Per-file CUDA compile option for sliding_window.cu

Layer / File(s) Summary
Per-file split compile disable for sliding_window.cu
cpp/CMakeLists.txt
Adds set_source_files_properties targeting src/routing/local_search/sliding_window.cu with COMPILE_OPTIONS set to --split-compile=0 to disable NVCC split compilation.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change: lowering optimization level for sliding_window.cu to work around an nvcc 13.0.3 compiler bug.
Description check ✅ Passed The description is directly related to the changeset, explaining the compiler issue, its cause, and how the CMake fix addresses it.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/sliding-window-nvcc-ice

Comment @coderabbitai help to get the list of available commands.

@ramakrishnap-nv
ramakrishnap-nv force-pushed the fix/sliding-window-nvcc-ice branch 4 times, most recently from 7c8e585 to 4dcbd6e Compare June 24, 2026 01:55
…_window.cu

nvcc 13.0.3 on x86_64 crashes (signal 11) compiling sliding_window.cu across 7
GPU architectures — the recursive if constexpr template combined with the large
multi-arch codegen exhausts compiler resources. --split-compile=0 breaks codegen
into per-arch sub-jobs, sidestepping the crash with no impact on runtime behavior.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@ramakrishnap-nv
ramakrishnap-nv force-pushed the fix/sliding-window-nvcc-ice branch from 4dcbd6e to 71e7334 Compare June 24, 2026 01:55
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot
rapids-bot Bot merged commit dd6a39f into main Jun 24, 2026
99 checks passed
@ramakrishnap-nv ramakrishnap-nv added this to the 26.08 milestone Jul 8, 2026
@ramakrishnap-nv
ramakrishnap-nv deleted the fix/sliding-window-nvcc-ice branch July 9, 2026 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants