fix(docker): pre-install test deps so dnf removal doesn't break test_image.sh - #1627
Merged
Merged
Conversation
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
ramakrishnap-nv
marked this pull request as ready for review
July 27, 2026 18:34
CI Test Summary⏭️ All 5 test job(s) skipped. |
tmckayus
approved these changes
Jul 27, 2026
📝 WalkthroughWalkthroughThe UBI Dockerfile now runs Python alternatives registration in a separate command from the RPM package-manager cleanup. ChangesPython alternatives registration
Estimated code review effort: 1 (Trivial) | ~5 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
… deps The cuopt-final stage was removing the entire RPM stack (dnf, rpm, curl, etc.) for attack-surface reduction, but this broke test_image.sh which calls `dnf install` at CI test time to install file/bzip2/gcc/wget/unzip. Since rpm is fully erased there is no way to reinstall or fix dnf at runtime. Remove the rpm-erase block so dnf stays in the image. CVE risk from retained packages (curl, dnf, rpm, python3-libs) will be tracked separately for security approval. Register python/python3 via alternatives directly (no longer needs to be deferred until after rpm %postun). Signed-off-by: Ramakrishna Prabhu <ramakrishnap@nvidia.com>
ramakrishnap-nv
force-pushed
the
fix/docker-test-image-dnf-not-found
branch
from
July 27, 2026 18:54
b2328af to
c251c2f
Compare
Collaborator
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_image.shcallsdnf installat CI test time, but thecuopt-finalDockerfile stage was removing the entire RPM stack (rpm -e --nodeps dnf rpm curl ...), leaving no way to install packages at runtime.Remove the rpm-erase block so
dnfstays in the image. CVE risk from retained packages (curl,dnf,rpm,python3-libs) is tracked separately for security approval.