Skip to content

test(barrier): cap qplib_8515_ruiz_forced_off at the iteration limit - #1628

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
mlubin:test/barrier-qplib8515-iteration-limit
Jul 28, 2026
Merged

test(barrier): cap qplib_8515_ruiz_forced_off at the iteration limit#1628
rapids-bot[bot] merged 1 commit into
NVIDIA:mainfrom
mlubin:test/barrier-qplib8515-iteration-limit

Conversation

@mlubin

@mlubin mlubin commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

The test was flaky because sometimes it never converged. Enforce an iteration limit instead.

Forcing Ruiz equilibration off leaves QPLIB_8515's column imbalance in place, so the barrier can't converge quickly. Cap the solve at 50 iterations and assert it stops at the iteration limit -- equivalent to the previous ">50 iterations" check, and it doesn't depend on number_of_steps_taken, which the barrier only populates on an optimal exit.

Signed-off-by: Miles Lubin <mlubin@nvidia.com>
@mlubin
mlubin requested a review from a team as a code owner July 28, 2026 13:56
@mlubin
mlubin requested review from aliceb-nv and yuwenchen95 July 28, 2026 13:56
@copy-pr-bot

copy-pr-bot Bot commented Jul 28, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@mlubin mlubin added bug Something isn't working non-breaking Introduces a non-breaking change labels Jul 28, 2026
@mlubin

mlubin commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test e8d6a57

@coderabbitai

coderabbitai Bot commented Jul 28, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Enterprise

Run ID: d4099b66-7e56-4d5f-b4b3-7c595e555343

📥 Commits

Reviewing files that changed from the base of the PR and between 74e3866 and e8d6a57.

📒 Files selected for processing (1)
  • cpp/tests/dual_simplex/unit_tests/solve_barrier.cu

📝 Walkthrough

Walkthrough

Changes

Barrier solver test behavior

Layer / File(s) Summary
Enforce and assert iteration limit
cpp/tests/dual_simplex/unit_tests/solve_barrier.cu
The test disables Ruiz equilibration, sets iteration_limit to 50, and asserts IterationLimit termination instead of checking the step count.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Suggested reviewers: aliceb-nv, yuwenchen95, chris-maes

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the test change to cap qplib_8515_ruiz_forced_off at the iteration limit.
Description check ✅ Passed The description is directly related to the change and explains the test flakiness and iteration-limit fix.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Comment @coderabbitai help to get the list of available commands.

@Bubullzz Bubullzz left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clean fix. thanks Miles

@github-actions

Copy link
Copy Markdown

CI Test Summary

✅ All 31 test job(s) passed.

@mlubin

mlubin commented Jul 28, 2026

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit df509f3 into NVIDIA:main Jul 28, 2026
93 checks passed
@mlubin
mlubin deleted the test/barrier-qplib8515-iteration-limit branch July 28, 2026 15:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants