test(barrier): cap qplib_8515_ruiz_forced_off at the iteration limit - #1628
Merged
rapids-bot[bot] merged 1 commit intoJul 28, 2026
Merged
Conversation
Forcing Ruiz equilibration off leaves QPLIB_8515's column imbalance in place, so the barrier can't converge quickly. Cap the solve at 50 iterations and assert it stops at the iteration limit -- equivalent to the previous ">50 iterations" check, and it doesn't depend on number_of_steps_taken, which the barrier only populates on an optimal exit. Signed-off-by: Miles Lubin <mlubin@nvidia.com>
Contributor
Author
|
/ok to test e8d6a57 |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthroughChangesBarrier solver test behavior
Estimated code review effort: 1 (Trivial) | ~2 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Bubullzz
approved these changes
Jul 28, 2026
rg20
approved these changes
Jul 28, 2026
CI Test Summary✅ All 31 test job(s) passed. |
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test was flaky because sometimes it never converged. Enforce an iteration limit instead.