modify ldconfig in ubi image so nvidia libraries are on path - #1644
Merged
Conversation
tmckayus
added
bug
CI Test Summary⏭️ All 5 test job(s) skipped. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Enterprise Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughChangesNVIDIA linker configuration
Estimated code review effort: 2 (Simple) | ~10 minutes Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@ci/docker/Dockerfile.ubi`:
- Around line 90-93: Update the NCCL validation in the Dockerfile command chain
after ldconfig to match libnccl.so.2 entries specifically under the discovered
/nvidia/nccl/lib directory, while allowing versioned filenames rather than
requiring an exact unversioned name. Keep the existing wheel-directory
configuration and ldconfig steps unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Enterprise
Run ID: 45060e5f-630d-4072-bcdf-0bd19db370e4
📒 Files selected for processing (1)
ci/docker/Dockerfile.ubi
ramakrishnap-nv
left a comment
ramakrishnap-nv
left a comment
Collaborator
There was a problem hiding this comment.
Rest looks good, and if possible add a test run this in ubi image.
under rhel, libcuopt and other libs end up under different paths so relative references don't work.
ramakrishnap-nv
approved these changes
Jul 31, 2026
Collaborator
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
under rhel, libcuopt and other libs end up under different paths so relative references don't work. This causes the cuopt_grpc_server to fail in the ubi10 image
$ docker run --rm --gpus=all --network=host -e CUOPT_SERVER_TYPE=grpc nvidia/cuopt:26.8.0a-cu13-ubi10 /usr/local/lib64/python3.14/site-packages/libcuopt/bin/cuopt_grpc_server: error while loading shared libraries: libnccl.so.2: cannot open shared object file: No such file or directorywith fix:
$ docker run --rm --gpus=all --network=host -e CUOPT_SERVER_TYPE=grpc cuopt-ubi10-nccl-fixtest:latest [2026-07-31 00:01:33.702] cuOpt gRPC Remote Solve Server [2026-07-31 00:01:33.702] ============================== [2026-07-31 00:01:33.702] Port: 5001 [2026-07-31 00:01:33.702] Workers: 1 [2026-07-31 00:01:33.730] [Server] 1 GPU(s) available for worker assignment [2026-07-31 00:01:33.734] [Worker 0] Started (PID: 58) [2026-07-31 00:01:33.735] [Server] Result retrieval thread started [2026-07-31 00:01:33.735] [Server] Incumbent retrieval thread started [2026-07-31 00:01:33.735] [Server] Worker monitor thread started [2026-07-31 00:01:33.736] [Server] Session reaper thread started (timeout=300s) [2026-07-31 00:01:33.742] [gRPC Server] Listening on 0.0.0.0:5001 [2026-07-31 00:01:33.742] [gRPC Server] Workers: 1 [2026-07-31 00:01:33.742] [gRPC Server] Max message size: 268435456 bytes (256 MiB) [2026-07-31 00:01:33.742] [gRPC Server] Press Ctrl+C to shutdown [2026-07-31 00:01:33.891] [Worker] RMM pool size: 1 GiB [2026-07-31 00:01:33.891] [Worker 0] Using CUDA device 0 of 1