Skip to content

Fix versioning for nightly and release package - #175

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-25.08from
ramakrishnap-nv:fix_nightly_wheel_naming
Jul 1, 2025
Merged

Fix versioning for nightly and release package #175
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-25.08from
ramakrishnap-nv:fix_nightly_wheel_naming

Conversation

@ramakrishnap-nv

@ramakrishnap-nv ramakrishnap-nv commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator

Description

This PR adds changes which updates version based on git tag so that nightly and release packages can be differentiated.

Issue

closes #167

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner July 1, 2025 16:01
@ramakrishnap-nv
ramakrishnap-nv requested a review from vyasr July 1, 2025 16:01
@ramakrishnap-nv ramakrishnap-nv self-assigned this Jul 1, 2025
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality breaking Introduces a breaking change and removed non-breaking Introduces a non-breaking change labels Jul 1, 2025
@ramakrishnap-nv ramakrishnap-nv added this to the 25.08 milestone Jul 1, 2025
@ramakrishnap-nv
ramakrishnap-nv requested a review from jameslamb July 1, 2025 16:01
@ramakrishnap-nv ramakrishnap-nv changed the title Fix versioning for nightly and release packages Fix versioning for nightly and release package naming Jul 1, 2025
@ramakrishnap-nv ramakrishnap-nv changed the title Fix versioning for nightly and release package naming Fix versioning for nightly and release package Jul 1, 2025

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks correct to me.

Spot-checked some logs and see the expected versions, e.g.

Checking 
/tmp/wheelhouse/cuopt_mps_parser-25.8.0a40-cp312-cp312-manylinux_2_24_x86_64.man

(build link)

@gforsyth

gforsyth commented Jul 1, 2025

Copy link
Copy Markdown
Collaborator

Also should have noted in my review, the conda builds are already using rapids-generate-version so there is no additional change needed there.

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

Also created a follow-up request to delete older wheels with wrong naming https://github.com/rapidsai/ops/issues/4078

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot
rapids-bot Bot merged commit 24063cc into NVIDIA:branch-25.08 Jul 1, 2025
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
This PR adds changes which updates version based on git tag so that nightly and release packages can  be differentiated.

## Issue
closes NVIDIA#167

Authors:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - Gil Forsyth (https://github.com/gforsyth)
  - James Lamb (https://github.com/jameslamb)

URL: NVIDIA#175
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

breaking Introduces a breaking change improvement Improves an existing functionality

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] Nightly cuOpt packages are getting built without "a" in their wheel name

3 participants