Skip to content

align service api with SDK (compat with deprecations) - #227

Merged
rapids-bot[bot] merged 22 commits into
NVIDIA:branch-25.08from
tmckayus:apisync
Jul 29, 2025
Merged

align service api with SDK (compat with deprecations)#227
rapids-bot[bot] merged 22 commits into
NVIDIA:branch-25.08from
tmckayus:apisync

Conversation

@tmckayus

@tmckayus tmckayus commented Jul 23, 2025

Copy link
Copy Markdown
Contributor

The service API is not aligned completely with the SDK API from 25.05 in relation to solver configs. This change brings them into alignment with deprecation notices and backward compatibility

@tmckayus
tmckayus requested a review from a team as a code owner July 23, 2025 14:17
@tmckayus
tmckayus requested a review from Iroy30 July 23, 2025 14:17
@tmckayus tmckayus added bug Something isn't working non-breaking Introduces a non-breaking change labels Jul 23, 2025
@tmckayus tmckayus changed the title [WIP] align service api with SDK (compat with deprecations) align service api with SDK (compat with deprecations) Jul 23, 2025
@tmckayus

tmckayus commented Jul 23, 2025

Copy link
Copy Markdown
Contributor Author

closes #193
closes #197

@tmckayus

tmckayus commented Jul 24, 2025

Copy link
Copy Markdown
Contributor Author

realized that on the clientside, ThinclientSolverSettings also needs to be fixed up

ramakrishnap-nv
ramakrishnap-nv reviewed Jul 24, 2025
View reviewed changes

@ramakrishnap-nv ramakrishnap-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CUOPT_MIP_HEURISTICS_ONLY needs to be updated in docs section.

Also lets add tests to make sure the naming changes are in good shape.

Comment thread python/cuopt_server/cuopt_server/utils/linear_programming/solver.py
@tmckayus
tmckayus requested a review from a team as a code owner July 25, 2025 18:09
@tmckayus
tmckayus requested a review from gforsyth July 25, 2025 18:09
@tmckayus

tmckayus commented Jul 25, 2025

Copy link
Copy Markdown
Contributor Author

CUOPT_MIP_HEURISTICS_ONLY needs to be updated in docs section.

Also lets add tests to make sure the naming changes are in good shape.

ok fixed the doc and added a dataset that sets all solver_config values for LP to make sure none are rejected
Testing the precedence of current vs deprecated I think is overkill.

ramakrishnap-nv
ramakrishnap-nv reviewed Jul 28, 2025
View reviewed changes

@ramakrishnap-nv ramakrishnap-nv left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @tmckayus, changes look good.

Have few minor doc related suggestions, I am approving the PR. So you can push those changes and merge once it is ready.

Comment thread python/cuopt_server/cuopt_server/webserver.py Outdated
@ramakrishnap-nv ramakrishnap-nv added this to the 25.08 milestone Jul 28, 2025
@copy-pr-bot

copy-pr-bot Bot commented Jul 29, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tmckayus

tmckayus commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

/ok to test 03966cf

@tmckayus

tmckayus commented Jul 29, 2025

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 8dc24a7 into NVIDIA:branch-25.08 Jul 29, 2025
210 of 215 checks passed
@ramakrishnap-nv ramakrishnap-nv mentioned this pull request Aug 8, 2025
Closed
@tmckayus
tmckayus deleted the apisync branch February 5, 2026 14:51
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
@tmckayus
align service api with SDK (compat with deprecations) (NVIDIA#227)
035366e 
The service API is not aligned completely with the SDK API from 25.05 in relation to solver configs. This change brings them into alignment with deprecation notices and backward compatibility

Authors:
  - Trevor McKay (https://github.com/tmckayus)
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - Gil Forsyth (https://github.com/gforsyth)
  - Ramakrishnap (https://github.com/rgsl888prabhu)

URL: NVIDIA#227
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gforsyth gforsyth gforsyth approved these changes
@ramakrishnap-nv ramakrishnap-nv ramakrishnap-nv approved these changes
@Iroy30 Iroy30 Awaiting requested review from Iroy30 Iroy30 is a code owner automatically assigned from NVIDIA/cuopt-infra-codeowners
@chris-maes chris-maes Awaiting requested review from chris-maes

Assignees

No one assigned

Labels

bug Something isn't working non-breaking Introduces a non-breaking change

Projects

None yet

Milestone

25.08

Development

Successfully merging this pull request may close these issues.

3 participants

@tmckayus @gforsyth @ramakrishnap-nv