Don't remove empty columns with infinite bounds - #287
Merged
rapids-bot[bot] merged 2 commits intoAug 12, 2025
Conversation
chris-maes
added
bug
Contributor
Author
|
/ok to test 0c0cf43 |
akifcorduk
approved these changes
Aug 12, 2025
akifcorduk
left a comment
akifcorduk
left a comment
Contributor
There was a problem hiding this comment.
Thanks Chris! Do you think it could be related to the bug that submip has on refactorization ?
Contributor
Author
|
/merge |
Contributor
Author
@akifcorduk perhaps, if you have empty columns in the submip |
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
Dual simplex presolve had an assert to prevent it from removing an empty column with a variable with an infinite bounds. This PR removes the assert and just skips variables with infinite bounds. This fixes Issue NVIDIA#270 Authors: - Chris Maes (https://github.com/chris-maes) Approvers: - Akif ÇÖRDÜK (https://github.com/akifcorduk) URL: NVIDIA#287
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dual simplex presolve had an assert to prevent it from removing an empty column with a variable with an infinite bounds.
This PR removes the assert and just skips variables with infinite bounds.
This fixes Issue #270