Skip to content

Performance tweak for dual_simplex/right_looking_lu - #315

Merged
rapids-bot[bot] merged 6 commits into
NVIDIA:branch-25.10from
ahehn-nv:ahehn/right_looking_lu_fix
Aug 26, 2025
Merged

Performance tweak for dual_simplex/right_looking_lu#315
rapids-bot[bot] merged 6 commits into
NVIDIA:branch-25.10from
ahehn-nv:ahehn/right_looking_lu_fix

Conversation

@ahehn-nv

Copy link
Copy Markdown
Contributor

Description

Small performance optimization of right_looking_lu() and right_looking_lu_row_permutation_only().

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@ahehn-nv
ahehn-nv requested a review from a team as a code owner August 18, 2025 10:12
@ahehn-nv
ahehn-nv requested review from Kh4ster and nguidotti August 18, 2025 10:12
@copy-pr-bot

copy-pr-bot Bot commented Aug 18, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Comment thread cpp/src/dual_simplex/right_looking_lu.cpp
@Kh4ster
Kh4ster removed the request for review from nguidotti August 18, 2025 10:35
@Kh4ster Kh4ster added non-breaking Introduces a non-breaking change dual_simplex improvement Improves an existing functionality labels Aug 18, 2025

@Kh4ster Kh4ster left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! Thanks!

@Kh4ster

Kh4ster commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Aug 18, 2025

Copy link
Copy Markdown

/ok to test

@Kh4ster, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@Kh4ster

Kh4ster commented Aug 18, 2025

Copy link
Copy Markdown
Contributor

/ok to test 41976b3

@anandhkb anandhkb added this to the 25.10 milestone Aug 18, 2025
@chris-maes

Copy link
Copy Markdown
Contributor

This is awesome. It should help in the following places:

  • Barrier dependent row check
  • Crossover initial factorization
  • Dual simplex factorization

It would be good to get a benchmark to see what the average improvement is here. I can try to do that.

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

/ok to test 0991429

@rg20

rg20 commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

/ok to test 501804d

@ahehn-nv

Copy link
Copy Markdown
Contributor Author

/ok to test 686ae64

@Kh4ster

Kh4ster commented Aug 25, 2025

Copy link
Copy Markdown
Contributor

/ok to test 686ae64

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

/ok to test 7b90bb1

@rg20

rg20 commented Aug 26, 2025

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit 86cd548 into NVIDIA:branch-25.10 Aug 26, 2025
73 checks passed
@chris-maes

Copy link
Copy Markdown
Contributor

/merge

nguidotti pushed a commit to nguidotti/cuopt that referenced this pull request Aug 28, 2025
Small performance optimization of `right_looking_lu()` and `right_looking_lu_row_permutation_only()`.

Authors:
  - https://github.com/ahehn-nv
  - Ramakrishnap (https://github.com/rgsl888prabhu)
  - Chris Maes (https://github.com/chris-maes)

Approvers:
  - Nicolas Blin (https://github.com/Kh4ster)

URL: NVIDIA#315
@ahehn-nv
ahehn-nv deleted the ahehn/right_looking_lu_fix branch September 8, 2025 11:45
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
Small performance optimization of `right_looking_lu()` and `right_looking_lu_row_permutation_only()`.

Authors:
  - https://github.com/ahehn-nv
  - Ramakrishnap (https://github.com/rgsl888prabhu)
  - Chris Maes (https://github.com/chris-maes)

Approvers:
  - Nicolas Blin (https://github.com/Kh4ster)

URL: NVIDIA#315
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dual_simplex improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants