Fix bug: dual simplex does not fill in additional info - #33
Merged
rapids-bot[bot] merged 4 commits intoMay 23, 2025
Conversation
Contributor
Author
|
/ok to test 4c3fa98 |
Kh4ster
reviewed
May 23, 2025
Kh4ster
approved these changes
May 23, 2025
Kh4ster
left a comment
Kh4ster
left a comment
Contributor
There was a problem hiding this comment.
Minor comments but overall good! Thanks!
Contributor
Author
|
/ok to test 90bb612 |
Contributor
Author
|
/ok to test 80350de |
Contributor
Author
|
/merge |
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
Adds additional termination info for dual simplex. This allows users to get the same info from either solver when using Concurrent mode. Authors: - Chris Maes (https://github.com/chris-maes) Approvers: - Nicolas Blin (https://github.com/Kh4ster) URL: NVIDIA#33
spoorendonk
added a commit
to spoorendonk/cuopt
that referenced
this pull request
Jun 22, 2026
The cuDSS device-memory-handler callbacks (cudss_device_alloc / cudss_device_dealloc) threw raft::cuda_error on a CUDA allocation failure. cuDSS invokes these as C callbacks during factorization, so unwinding a C++ exception through its C frames is undefined behaviour and can corrupt solver/GPU state — letting a failed (out-of-memory) factorization be reported as OPTIMAL with a garbage solution instead of a clean numerical error. Return the CUDA error code instead. cuDSS then fails the factorize deterministically, which the barrier's `status < 0` path maps to a non-optimal termination (NUMERICAL_ERROR). Fixes the nondeterministic garbage-as-optimal reported downstream (mcfcg NVIDIA#33).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds additional termination info for dual simplex. This allows users to get the same info from either solver when using Concurrent mode.