Skip to content

Reduce hard-coded version usage in repo - #337

Merged
rapids-bot[bot] merged 20 commits into
NVIDIA:branch-25.10from
ramakrishnap-nv:version_cleaning
Aug 27, 2025
Merged

Reduce hard-coded version usage in repo#337
rapids-bot[bot] merged 20 commits into
NVIDIA:branch-25.10from
ramakrishnap-nv:version_cleaning

Conversation

@ramakrishnap-nv

@ramakrishnap-nv ramakrishnap-nv commented Aug 21, 2025

Copy link
Copy Markdown
Collaborator

Description

Pr reduces number of hard coded versions in repo and also fixes few issues.

Issue

closes #329

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@ramakrishnap-nv
ramakrishnap-nv requested review from a team as code owners August 21, 2025 20:44
@ramakrishnap-nv ramakrishnap-nv self-assigned this Aug 21, 2025
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Aug 21, 2025

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking great! Thanks for considering this suggestion 😁

I left one very very very very small suggestion, do whatever you want with it and I don't need to review again.

Comment thread ci/utils/update_doc_versions.py Outdated
Comment thread python/cuopt_server/cuopt_server/utils/data_definition.py Outdated
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/merge

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

@rg20 @hlinsen may I get your review ?

@hlinsen hlinsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rapids-bot
rapids-bot Bot merged commit 4fd6f11 into NVIDIA:branch-25.10 Aug 27, 2025
73 checks passed
nguidotti pushed a commit to nguidotti/cuopt that referenced this pull request Aug 28, 2025
Pr reduces number of hard coded versions in repo and also fixes few issues.

## Issue
closes NVIDIA#329

Authors:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Trevor McKay (https://github.com/tmckayus)
  - Hugo Linsenmaier (https://github.com/hlinsen)

URL: NVIDIA#337
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
Pr reduces number of hard coded versions in repo and also fixes few issues.

## Issue
closes NVIDIA#329

Authors:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Trevor McKay (https://github.com/tmckayus)
  - Hugo Linsenmaier (https://github.com/hlinsen)

URL: NVIDIA#337
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Fix usage of too many version like YY.MM.XX in repository

4 participants