Skip to content

Adding support nightly cuopt-examples notebook testing - #342

Merged
rapids-bot[bot] merged 22 commits into
NVIDIA:branch-25.10from
ramakrishnap-nv:nightly_notebook_support
Sep 8, 2025
Merged

Adding support nightly cuopt-examples notebook testing #342
rapids-bot[bot] merged 22 commits into
NVIDIA:branch-25.10from
ramakrishnap-nv:nightly_notebook_support

Conversation

@ramakrishnap-nv

@ramakrishnap-nv ramakrishnap-nv commented Aug 22, 2025

Copy link
Copy Markdown
Collaborator

Description

This adds testing for https://github.com/NVIDIA/cuopt-examples to nightly testing suite.

Issue

closes #334
closes #212

Checklist

  • I am familiar with the Contributing Guidelines.
  • Testing
    • New or existing tests cover these changes
    • Added tests
    • Created an issue to follow-up
    • NA
  • Documentation
    • The documentation is up to date with these changes
    • Added new documentation
    • NA

@ramakrishnap-nv ramakrishnap-nv added this to the 25.10 milestone Aug 22, 2025
@ramakrishnap-nv ramakrishnap-nv self-assigned this Aug 22, 2025
@ramakrishnap-nv ramakrishnap-nv added the non-breaking Introduces a non-breaking change label Aug 22, 2025
@copy-pr-bot

copy-pr-bot Bot commented Aug 22, 2025

Copy link
Copy Markdown

Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually.

Contributors can view more details about this message here.

@ramakrishnap-nv ramakrishnap-nv added the improvement Improves an existing functionality label Aug 22, 2025
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test ce40ff8

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test ce40ff8

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test 5d04191

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test 7968bab

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test 7cf79c0

1 similar comment
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test 7cf79c0

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test 43e6418

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test 891408f

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test 65eac17

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/ok to test bba7a04

@ramakrishnap-nv
ramakrishnap-nv marked this pull request as ready for review August 29, 2025 20:23
@ramakrishnap-nv
ramakrishnap-nv requested a review from a team as a code owner August 29, 2025 20:23
@ramakrishnap-nv
ramakrishnap-nv requested review from Iroy30, bdice, jameslamb and tmckayus and removed request for bdice August 29, 2025 20:23
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

@jameslamb may I get your review on this PR

@jameslamb jameslamb left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks ok to me! I checked the logs (build link) and appreciate how informative they are, especially around the cleaning of ! commands which is the place where I think this is most likely to fail.

I think it's fine that the examples are coming from another repo since that repo is also in the NVIDIA org and controlled by similar security restrictions, branch protections, review standards, etc.

But you might in the future consider pinning to a specific commit of that repo instead of a branch ... otherwise, merges there could block all PR CI here.

And exciting that you were able to remove a bunch of unnecessary dependencies here!

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

This looks ok to me! I checked the logs (build link) and appreciate how informative they are, especially around the cleaning of ! commands which is the place where I think this is most likely to fail.

I think it's fine that the examples are coming from another repo since that repo is also in the NVIDIA org and controlled by similar security restrictions, branch protections, review standards, etc.

But you might in the future consider pinning to a specific commit of that repo instead of a branch ... otherwise, merges there could block all PR CI here.

And exciting that you were able to remove a bunch of unnecessary dependencies here!

Yeah, I am planning to keep it only for nightly and remove it from PR for exact same reasons that I don't want to block PRs.

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot
rapids-bot Bot merged commit 5b9a262 into NVIDIA:branch-25.10 Sep 8, 2025
201 of 202 checks passed
aliceb-nv pushed a commit that referenced this pull request Sep 22, 2025
This adds testing for https://github.com/NVIDIA/cuopt-examples to nightly testing suite.

## Issue

closes #334 
closes #212

Authors:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Trevor McKay (https://github.com/tmckayus)

URL: #342
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
This adds testing for https://github.com/NVIDIA/cuopt-examples to nightly testing suite.

## Issue

closes NVIDIA#334 
closes NVIDIA#212

Authors:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - James Lamb (https://github.com/jameslamb)
  - Trevor McKay (https://github.com/tmckayus)

URL: NVIDIA#342
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[FEA] Notification mechanism for notifying Nightly failures [FEA] Switch Conda from matplotlib to matplotlib-base

3 participants