Skip to content

[FIX] Do not run compression tests when compression is disabled. - #389

Merged
rapids-bot[bot] merged 3 commits into
NVIDIA:branch-25.10from
legrosbuffle:compression-tests
Sep 27, 2025
Merged

[FIX] Do not run compression tests when compression is disabled.#389
rapids-bot[bot] merged 3 commits into
NVIDIA:branch-25.10from
legrosbuffle:compression-tests

Conversation

@legrosbuffle

Copy link
Copy Markdown
Contributor

Those tests were introduced in
536488d, but they run even when compression is disabled.

Those tests were introduced in
536488d, but they run even when
compression is disabled.
@legrosbuffle
legrosbuffle requested a review from a team as a code owner September 11, 2025 09:04
@copy-pr-bot

copy-pr-bot Bot commented Sep 11, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@anandhkb anandhkb added this to the 25.10 milestone Sep 11, 2025
@ramakrishnap-nv ramakrishnap-nv added non-breaking Introduces a non-breaking change improvement Improves an existing functionality labels Sep 16, 2025
@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

@hlinsen @aliceb-nv may I get your review on this PR

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

/ok to test

@copy-pr-bot

copy-pr-bot Bot commented Sep 16, 2025

Copy link
Copy Markdown

/ok to test

@rgsl888prabhu, there was an error processing your request: E1

See the following link for more information: https://docs.gha-runners.nvidia.com/cpr/e/1/

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

/ok to test fa58413

@github-actions

Copy link
Copy Markdown

🔔 Hi @anandhkb @legrosbuffle, this pull request has had no activity for 7 days. Please update or let us know if it can be closed. Thank you!

If this is an "epic" issue, then please add the "epic" label to this issue.
If it is a PR and not ready for review, then please convert this to draft.
If you just want to switch off this notification, then use the "skip inactivity reminder" label.

@aliceb-nv aliceb-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

/ok to test dd00534

@aliceb-nv

Copy link
Copy Markdown
Contributor

/ok to test 108e46e

@aliceb-nv

Copy link
Copy Markdown
Contributor

/ok to test 108e46e

@aliceb-nv

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit abc1954 into NVIDIA:branch-25.10 Sep 27, 2025
257 of 260 checks passed
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
…DIA#389)

Those tests were introduced in
536488d, but they run even when compression is disabled.

Authors:
  - Clement Courbet (https://github.com/legrosbuffle)
  - Ramakrishnap (https://github.com/rgsl888prabhu)
  - Alice Boucher (https://github.com/aliceb-nv)

Approvers:
  - Alice Boucher (https://github.com/aliceb-nv)

URL: NVIDIA#389
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

improvement Improves an existing functionality non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants