Skip to content

Add optional timestamps enabled by env CUOPT_EXTRA_TIMESTAMPS - #392

Merged
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-25.10from
tmckayus:timestamps
Oct 3, 2025
Merged

Add optional timestamps enabled by env CUOPT_EXTRA_TIMESTAMPS#392
rapids-bot[bot] merged 4 commits into
NVIDIA:branch-25.10from
tmckayus:timestamps

Conversation

@tmckayus

Copy link
Copy Markdown
Contributor

This change adds optional internal timestamps which can be enabled with env var CUOPT_EXTRA_TIMESTAMPS=True.

The timestamps are to allow benchmarking scripts to key off of the events in order to calculate problem setup and teardown time.

@copy-pr-bot

copy-pr-bot Bot commented Sep 15, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@tmckayus tmckayus added feature request New feature or request non-breaking Introduces a non-breaking change labels Sep 15, 2025
@tmckayus

Copy link
Copy Markdown
Contributor Author

/ok to test b9bfccf

Comment thread cpp/src/linear_programming/cuopt_c.cpp Outdated
Comment thread python/cuopt/cuopt/linear_programming/solver/solver.py
Comment thread python/cuopt/cuopt/linear_programming/solver/solver.py
Comment thread cpp/src/linear_programming/cuopt_c.cpp Outdated
Comment thread cpp/src/linear_programming/cuopt_c.cpp Outdated
Comment thread cpp/src/linear_programming/cuopt_c.cpp Outdated
Comment thread cpp/src/linear_programming/cuopt_c.cpp Outdated
Comment thread cpp/src/linear_programming/cuopt_c.cpp Outdated
@anandhkb anandhkb added this to the 25.10 milestone Sep 15, 2025
@tmckayus
tmckayus requested a review from a team as a code owner September 16, 2025 19:28
@tmckayus

Copy link
Copy Markdown
Contributor Author

/ok to test 99c5ee9

@KyleFromNVIDIA KyleFromNVIDIA left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved trivial CMake changes

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

@rg20 @chris-maes May I get your review on this PR

@aliceb-nv aliceb-nv left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving C++

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

/ok to test 9de0f56

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

/ok to test 92fa733

@aliceb-nv

Copy link
Copy Markdown
Contributor

/merge

@rapids-bot
rapids-bot Bot merged commit f4d6791 into NVIDIA:branch-25.10 Oct 3, 2025
172 of 174 checks passed
@tmckayus
tmckayus deleted the timestamps branch February 5, 2026 14:51
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
…#392)

This change adds optional internal timestamps which can be enabled with env var CUOPT_EXTRA_TIMESTAMPS=True.

The timestamps are to allow benchmarking scripts to key off of the events in order to calculate problem setup and teardown time.

Authors:
  - Trevor McKay (https://github.com/tmckayus)

Approvers:
  - Kyle Edwards (https://github.com/KyleFromNVIDIA)
  - Alice Boucher (https://github.com/aliceb-nv)
  - Ramakrishnap (https://github.com/rgsl888prabhu)

URL: NVIDIA#392
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

feature request New feature or request non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants