add http timeout values for general, send, and receive to client - #404
Merged
Conversation
tmckayus
requested review from
Iroy30
and removed request for
ramakrishnap-nv
September 19, 2025 20:03
tmckayus
force-pushed
the
clienttimeouts
branch
from
September 22, 2025 13:56
94de422 to
c21cae5
Compare
tmckayus
force-pushed
the
clienttimeouts
branch
from
September 22, 2025 17:43
c21cae5 to
37a31bc
Compare
ramakrishnap-nv
approved these changes
Sep 22, 2025
Contributor
Author
|
/merge |
jieyibi
pushed a commit
to yining043/cuopt
that referenced
this pull request
Mar 26, 2026
…DIA#404) Some large datasets, or even smaller datasets on a slow network, may take more than 30s to transfer to the server. Add timeout parameters to the cuopt service client to control the timeouts, defaulted to 30s. Timeout parameters added: http_general_timeout (default 30), result_receive_timeout (default None), and data_send_timeout (default None). The latter two inherit the value of http_general_timeout if they are None. All 3 are settable in the client class, however only the general timeout is exposed in the CLI (which should be enough control). Authors: - Trevor McKay (https://github.com/tmckayus) Approvers: - Ramakrishnap (https://github.com/rgsl888prabhu) URL: NVIDIA#404
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some large datasets, or even smaller datasets on a slow network, may take more than 30s to transfer to the server. Add timeout parameters to the cuopt service client to control the timeouts, defaulted to 30s.
Timeout parameters added: http_general_timeout (default 30), result_receive_timeout (default None), and data_send_timeout (default None). The latter two inherit the value of http_general_timeout if they are None.
All 3 are settable in the client class, however only the general timeout is exposed in the CLI (which should be enough control).