Skip to content

Address cuOpt doc reviews - #41

Merged
rapids-bot[bot] merged 14 commits into
NVIDIA:branch-25.05from
ramakrishnap-nv:address_doc_reviews_1
May 29, 2025
Merged

Address cuOpt doc reviews #41
rapids-bot[bot] merged 14 commits into
NVIDIA:branch-25.05from
ramakrishnap-nv:address_doc_reviews_1

Conversation

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

Address VDR and VPR review comments

@ramakrishnap-nv ramakrishnap-nv changed the title Address cuOpt reviews Address cuOpt doc reviews May 27, 2025
@ramakrishnap-nv ramakrishnap-nv added doc Improvements or additions to documentation non-breaking Introduces a non-breaking change improvement Improves an existing functionality and removed improvement Improves an existing functionality labels May 27, 2025

@cwilkinson76 cwilkinson76 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All changes here look good to me

@chris-maes chris-maes left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread CONTRIBUTING.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread README.md Outdated
Comment thread CONTRIBUTING.md Outdated
Comment thread README.md Outdated
Comment thread README.md Outdated
Comment thread ci/README.md Outdated
Comment thread ci/README.md Outdated
Comment thread ci/README.md Outdated
Comment thread ci/README.md Outdated
Comment thread cpp/README.md Outdated
Comment thread cpp/README.md Outdated
Comment thread docs/cuopt/source/cuopt-c/quick-start.rst Outdated
Comment thread docs/cuopt/README.md Outdated
Comment thread docs/cuopt/README.md Outdated

@tmckayus tmckayus left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just a couple of typos I noticed

Comment thread docs/cuopt/source/cuopt-c/quick-start.rst Outdated
Comment thread docs/cuopt/source/cuopt-c/quick-start.rst Outdated
Comment thread docs/cuopt/source/faq.rst Outdated
Comment thread docs/cuopt/source/introduction.rst Outdated
Comment thread docs/cuopt/source/introduction.rst Outdated
Comment thread docs/cuopt/source/system-requirements.rst Outdated
Comment thread docs/cuopt/source/system-requirements.rst Outdated
Comment thread python/README.md Outdated
Comment thread python/README.md Outdated
Comment thread python/README.md Outdated
Comment thread python/README.md Outdated

@cwilkinson76 cwilkinson76 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments where changes are needed

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator Author

/merge

@rapids-bot
rapids-bot Bot merged commit f4cd784 into NVIDIA:branch-25.05 May 29, 2025
jieyibi pushed a commit to yining043/cuopt that referenced this pull request Mar 26, 2026
Address VDR and VPR review comments

Authors:
  - Ramakrishnap (https://github.com/rgsl888prabhu)

Approvers:
  - Cindy Wilkinson (https://github.com/cwilkinson76)
  - Chris Maes (https://github.com/chris-maes)
  - Rajesh Gandham (https://github.com/rg20)
  - Trevor McKay (https://github.com/tmckayus)

URL: NVIDIA#41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

doc Improvements or additions to documentation non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants