Skip to content

Don't eliminate free variables in dual simplex - #457

Merged
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-25.10from
chris-maes:free_vars_dual_simplex
Oct 7, 2025
Merged

Don't eliminate free variables in dual simplex#457
rapids-bot[bot] merged 1 commit into
NVIDIA:branch-25.10from
chris-maes:free_vars_dual_simplex

Conversation

@chris-maes

Copy link
Copy Markdown
Contributor

Fixes an issue where free variables were being eliminated in dual simplex. These variables should only be eliminated when using barrier.

@chris-maes
chris-maes requested a review from a team as a code owner October 7, 2025 16:37
@copy-pr-bot

copy-pr-bot Bot commented Oct 7, 2025

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@chris-maes chris-maes added bug Something isn't working non-breaking Introduces a non-breaking change dual_simplex labels Oct 7, 2025
@chris-maes chris-maes added this to the 25.10 milestone Oct 7, 2025
@chris-maes

Copy link
Copy Markdown
Contributor Author

/ok to test 6726254

@ramakrishnap-nv

Copy link
Copy Markdown
Collaborator

@chris-maes PR is failing with following test failures https://github.com/NVIDIA/cuopt/actions/runs/18319680798/job/52175602693?pr=457#step:10:3845
https://github.com/NVIDIA/cuopt/actions/runs/18319680798/job/52175602687?pr=457#step:10:4559

FAILED tests/test_pdlp_warmstart.py::test_warmstart - assert (36800 + 104480) == 136280

https://github.com/NVIDIA/cuopt/actions/runs/18319680798/job/52174832887?pr=457#step:10:2140
[ FAILED ] c_api/TimeLimitTestFixture.time_limit/1, where GetParam() = ("/linear_programming/square41/square41.mps", 5, 1)

@chris-maes

Copy link
Copy Markdown
Contributor Author

@chris-maes PR is failing with following test failures https://github.com/NVIDIA/cuopt/actions/runs/18319680798/job/52175602693?pr=457#step:10:3845 https://github.com/NVIDIA/cuopt/actions/runs/18319680798/job/52175602687?pr=457#step:10:4559

FAILED tests/test_pdlp_warmstart.py::test_warmstart - assert (36800 + 104480) == 136280

https://github.com/NVIDIA/cuopt/actions/runs/18319680798/job/52174832887?pr=457#step:10:2140 [ FAILED ] c_api/TimeLimitTestFixture.time_limit/1, where GetParam() = ("/linear_programming/square41/square41.mps", 5, 1)

@rgsl888prabhu that is strange. This commit should only affect dual simplex and barrier. It would not affect PDLP warm start or a MIP solve time test. I re-triggered the tests. Let's see if they fail again.

@chris-maes

Copy link
Copy Markdown
Contributor Author

/merge

@rapids-bot
rapids-bot Bot merged commit 1ad4af4 into NVIDIA:branch-25.10 Oct 7, 2025
172 of 177 checks passed
@chris-maes
chris-maes deleted the free_vars_dual_simplex branch October 7, 2025 20:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working dual_simplex non-breaking Introduces a non-breaking change

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants