Gracefully handle OOM in Barrier - #483
Merged
Merged
Conversation
hlinsen
added
bug
hlinsen
force-pushed
the
fix-dlr2
branch
2 times, most recently
from
October 10, 2025 21:22
4d94a40 to
0e95be5
Compare
chris-maes
reviewed
Oct 10, 2025
chris-maes
reviewed
Oct 10, 2025
chris-maes
reviewed
Oct 10, 2025
chris-maes
reviewed
Oct 10, 2025
chris-maes
approved these changes
Oct 10, 2025
chris-maes
left a comment
chris-maes
left a comment
Contributor
There was a problem hiding this comment.
LGTM. Thanks @hlinsen !
Contributor
Author
|
/merge |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CUDSS does not throw on OOM and even though we check for the return status. There was a sticky cuda error on any successive CUDA API call. A workaround is to throw if
cudaMallocAsyncfails in the device mem handler and catch that error in the solve method.