[REVIEW] Fix assertion in fill_indices_by_rows_kernel. - #2732
Merged
Conversation
The cumulative number of nnz per row must be smaller than the total number of nnz, not the other way around.
Contributor
|
Can you explain a bit of your workflow that led you to finding this bug? |
Contributor
Author
This assert fires when building with |
Contributor
|
/ok to test 2cef544 |
Contributor
|
@legrosbuffle I would have to confirm again but I think we test |
divyegala
approved these changes
Jul 8, 2025
Contributor
|
/ok to test 509904e |
Member
|
@divyegala merge? |
Contributor
|
/merge |
github-project-automation
Bot
moved this from In Progress
to Done
in Unstructured Data Processing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The cumulative number of nnz per row must be smaller than the total number of nnz, not the other way around.