feat(settings): add gyroscope controls toggle - #556
Conversation
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_f2518b28-53da-4e81-b4df-95f0c1e26912) |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0383fd91df
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| checked={settings.enableGyroscopeControls} | ||
| onChange={(e) => handleChange("enableGyroscopeControls", e.target.checked)} |
There was a problem hiding this comment.
Wire the gyro toggle into streaming
When a user enables this checkbox and then starts a stream, nothing downstream observes the value: buildCurrentStreamSettings() only forwards the existing stream fields into the WebRTC/native paths, and a repo-wide rg enableGyroscopeControls shows only the settings defaults/types and this UI. As a result the new setting is persisted but cannot actually expose motion sensors for either input backend.
Useful? React with 👍 / 👎.
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This PR adds an experimental toggle for gyroscope controller input mapping to address issue #226.
enableGyroscopeControlsboolean to shared and mainSettingsinterfacesNote
Low Risk
Settings and UI-only change with default off; no stream or input pipeline behavior is modified in this diff.
Overview
Adds an experimental Gyroscope Controls option under Input settings (Beta badge, hint text, English strings) so users can persist a preference for controller motion-sensor / gyro aiming when the input stack supports it.
Introduces
enableGyroscopeControlson shared/mainSettings, default off, with renderer defaults aligned and the Input settings search index extended for controller/gyro terms. This PR does not add runtime wiring from the flag into WebRTC or native input in the changed files—only storage and UI.Reviewed by Cursor Bugbot for commit 0383fd9. Configure here.