fix(ui): unify dropdowns, fix settings scroll, About/Thanks enhancements, external link guards - #616
Merged
Merged
Conversation
…ut, and enforce external URLs Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Chizuui
pushed a commit
to Chizuui/OpenNOW-Modified
that referenced
this pull request
Aug 11, 2026
…ut, and enforce external URLs (OpenCloudGaming#616) Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses 6 UI issues: replaces native selects with a custom dark dropdown, prevents settings scroll persisting across tabs, makes poster scale steps visible, moves What's New to top of About, centers Thanks hero heart, and blocks in-app navigation for external links.
UI Components
SelectDropdowncomponent matching dark design with keyboard navigation, ARIA roles, and controller supportHomePage/LibraryPagesort controls withSelectDropdown(Settings storage select remains native as-disabled/read-only)home.sortAriaLabel/library.sortAriaLabeltolocales/en.jsonSettings Page
.settings-contentscrollTop to 0 onactiveSectionchange via ref + effectGrid Scaling
--game-poster-scale, ensuring every 5% step produces visible width change without overflowVisual Polish
Main Process
setWindowOpenHandlerandwill-navigateguard insrc/main/index.tsto prevent navigating app window away and open external http(s) URLs in default browser viashell.openExternalOPEN_EXTERNAL_URLlogicFile changes preserve CRLF line endings; typecheck and locales:check pass.
Note
Low Risk
Changes are mostly renderer UI/CSS; main-process navigation guards are a small, positive hardening of external link handling with limited blast radius.
Overview
Adds a shared
SelectDropdown(dark theme, keyboard/ARIA, controller-friendly) and swaps native sort controls on Home and Library for it, with newhome.sortAriaLabel/library.sortAriaLabelstrings and hiding sort when there are no options. Settings uses the same component for the read-only storage location row, scrolls.settings-contentback to the top when the active section or search-all mode changes, and moves What's New above Application Updates in About.CSS introduces dropdown styling, tightens game grid poster sizing with a clamped
--game-poster-widthso poster scale steps read clearly, and nudges Thanks hero icon alignment.Electron main centralizes HTTP(S) external opens, blocks in-window navigation away from the app (and denies
window.open), routing allowed external links throughshell.openExternal—reused byOPEN_EXTERNAL_URL.Reviewed by Cursor Bugbot for commit 7a5ea1c. Configure here.