Post editor: always iframe - #74042
Conversation
t-hamano
left a comment
There was a problem hiding this comment.
It's going to take some courage for me to merge this, but let's try it as soon as possible 😅
P.S. Some E2E tests may fail, so we'll need to fix them. Try searching for // To do: run with iframe. or switchToLegacyCanvas() for tests.
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Unlinked AccountsThe following contributors have not linked their GitHub and WordPress.org accounts: @chimok, @tcmulder. Contributors, please read how to link your accounts to ensure your work is properly credited in WordPress releases. If you're merging code through a pull request on GitHub, copy and paste the following into the bottom of the merge commit message. To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
|
Maybe |
|
Size Change: -313 B (0%) Total Size: 7.61 MB 📦 View Changed
|
|
@t-hamano Yeah, I'm aware, I'm intentionally letting them fail once so I can catch them all at once |
|
Oh wow, I didn't know there's no many cases of |
|
Thank you, Ella! Besides fixing the e2e tests, we should probably scan the WP.org directory for blocks that are still using the old API versions and send them a friendly notification with a migration guide. IIRC, this has been done before, so there will be folks who can help us. Let's coordinate this effort after the holidays. |
|
It's after the holidays and we're a month away from beta 1. @justintadlock could you potentially help with this kind of review above?
|
|
Yes, let me clean up the e2e test and let's get this in trunk asap. |
d8eac59 to
2127944
Compare
|
It can be done separately but there is some styling to update or remove. Mostly to do with the class name added here: Also, I think a few private components in the editor package have related props that can be removed. |
2127944 to
98f7dd5
Compare
98f7dd5 to
3d665d0
Compare
3d665d0 to
428790e
Compare
I'm not sure if we should remove it from the block editor's canvas component. We should still allow third party developers to build editors without an iframe. Some use cases may not require style isolation etc. |
The post editor now always renders inside an iframe, so update the migration guide to state the WordPress 7.1 behavior as final rather than planned and note that the 7.0 conditional fallback is removed. Co-Authored-By: Claude <noreply@anthropic.com>
The post editor is always iframed, so nothing passes disableIframe down and VisualEditor no longer accepts it. Remove the dead prop plumbing. Co-Authored-By: Claude <noreply@anthropic.com>
With the post editor always iframed, several conditions are now constant. Drop the always-true `is-iframed` class and inline its `overflow: hidden` rule, and remove the `MetaBoxesMain` `isLegacy` prop (always false) along with its legacy split-view branch. Co-Authored-By: Claude <noreply@anthropic.com>
|
All dead code has been removed. |
|
Thanks, @t-hamano!
I understand. IMO, all past cautions and changes were leading to this. We'll have to make a final decision at some point. P.S. It would be good to share this with others in the release squad for a (extra) thumbs-up. |
|
@annezazu @joedolson @ellatrix @youknowriad @Mamaduka @mcsf @stokesman I am pinging the release lead for version 7.1, the tech lead, and everyone who contributed to this effort. With this pull request, we propose to force an iframe for the post editor in the 7.1 release. Please refer to this document for background information:
This PR might cause issues for blocks that do not yet support iframes, but we have been urging testing in the iframe editor for years. Furthermore, since the iframe editor has been enforced for several months whenever the Gutenberg plugin is active, any problems should have been reported on WordPress.com where the Gutenberg plugin is enabled. The more cautious alternative in the 7.1 release is #79819. This approach enforces the post editor only for block themes. |
|
I assume if we proceed with this approach ahead of beta 1 and a lot of feedback is given after beta 1 that there are issues, we can move to the softer approach. Assuming that is correct, I am okay proceeding as is. I agree we've given this a lot of time. @justintadlock can I lean on your folks to get the word out here and start preparing content around this? |
|
Based on the reactions and comments, I believe we have received generally positive feedback on this PR. If there are no further objections, I intend to merge this next week before Beta 1. |
|
I will test further after this is merged. I don't believe that anything has changed from the accessibility perspective; the |
|
For now, let's merge this, and if the impact is too significant, we can try a more conservative approach. |
|
Sounds good, when we get reports of issues, we can figure out ways to move forward from there instead of working with hypotheticals |
This updates the pinned commit hash of the Gutenberg repository from `b5574edc8a952b2f1e528693761a97b1b3b580eb` (version `23.5.0`) to `2872d71cde528d82675f14862a1b84e2b8abbaea` (version `23.6.0 RC1`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.5.0..v23.6.0-rc.1. - IconButton: Use length zero for inline padding (WordPress/gutenberg#79722) - Button: Align focus styles with design system (WordPress/gutenberg#78646) - Remove playlist border radius support (WordPress/gutenberg#79753) - ExternalLink: Stop setting default rel (WordPress/gutenberg#79743) - Icons: Validate SVG icons include currentColor (WordPress/gutenberg#79751) - Tests: Fix flaky 'GIF to Video' e2e test (WordPress/gutenberg#79758) - CSS: Follow-up fixes to split_selector_list() (WordPress/gutenberg#79723) - Automated Testing: Enforce no-unresolved checks for test files (WordPress/gutenberg#79718) - Fix and permit unitless zeros used in CSS `calc` functions (WordPress/gutenberg#79786) - Components: migrate View away from Emotion (WordPress/gutenberg#79443) - Badge: update storybook with "don't use icons" example (WordPress/gutenberg#79585) - Tabs: Prevent tab list from moving focus during revision navigation (WordPress/gutenberg#79730) - Embed: Refactor 'EmbedPlaceholder' to use recommended components (WordPress/gutenberg#79759) - RTC: Remove collaboration notification defaults filter (WordPress/gutenberg#79771) - Tests: Honor waitForUploadQueueEmpty timeout in client-side media (WordPress/gutenberg#79783) - lintstaged: Avoid appending filenames to the `prelint:js` command (WordPress/gutenberg#79800) - Guidelines: Render block icons like the editor so every icon displays correctly (WordPress/gutenberg#79738) - Isolated mode: Fix bin resolution, type mismatch, and missing dependencies (WordPress/gutenberg#79806) - Duotone: Use HTML API class_list for duotone wrapper class handling (WordPress/gutenberg#79531) - Deprecate `@wordpress/reusable-blocks` public APIs (WordPress/gutenberg#79805) - UI: add LinkButton (WordPress/gutenberg#78944) - Block Library: Replace obsolete `View` primitive with plain `div` (WordPress/gutenberg#79767) - Site Editor: Update default theme color from fresh to modern (WordPress/gutenberg#79814) - Prevent overscroll bounce for stage and inspector surfaces (WordPress/gutenberg#78587) - Widgets: add attribute `relevance` and inline editing in the tile toolbar (WordPress/gutenberg#79735) - Automated Testing: Configure lint:css to report needless disables (WordPress/gutenberg#79788) - FormTokenField: Hard deprecate 40px default size (WordPress/gutenberg#79720) - UnitControl: Hard deprecate 40px default size (WordPress/gutenberg#79721) - Omnibar: move the 'site icon in admin bar' feature from experiment to 7.1 compat (WordPress/gutenberg#79807) - Update waveform player dependency to bring in upstream a11y improvements (WordPress/gutenberg#79825) - Backport changelog and package version updates from NPM (WordPress/gutenberg#79816) - Block variations: Support innerContent for the Custom HTML block (WordPress/gutenberg#79659) - Packages: Polish release changelog headings (WordPress/gutenberg#79826) - Theme: Clarify focus token naming docs (WordPress/gutenberg#79764) - Media: Return the filtered `wp_editor_set_quality` value in the upload response (WordPress/gutenberg#78420) - Media: Backport client-side media improvements from WordPress core backports (WordPress/gutenberg#79603) - Dynamic Gallery Block: Add a dynamic mode of the gallery block (WordPress/gutenberg#78796) - Global Styles: Match block panel order to the block inspector (WordPress/gutenberg#79794) - Verse block: add background gradient support (WordPress/gutenberg#79391) - UI: Add Skeleton component (WordPress/gutenberg#79671) - Widgets: add a declarative `help` metadata field, surfaced as a header infotip (WordPress/gutenberg#79830) - CustomSelectControl: Hard deprecate 40px default size (WordPress/gutenberg#79796) - Use subscribeDelegatedListener for selectionchange in rich text (WordPress/gutenberg#79712) - Vips: preserve bit depth of high-bit-depth AVIF in sub-sizes (WordPress/gutenberg#79556) - DataViews: Fix infinite-scroll jump on async page loads (WordPress/gutenberg#79546) - Added Missing Global Documentation (WordPress/gutenberg#79827) - Vips: Add positional-crop test for high-bit-depth AVIF (WordPress/gutenberg#79880) - Responsive style states: Update responsive editing help text and avoid showing desktop badge (WordPress/gutenberg#79615) - Packages: Update Ariakit to 0.4.32 (WordPress/gutenberg#79860) - Block position: Allow options dropdown to flip (WordPress/gutenberg#79798) - Command Palette: show the search icon on desktop as well (WordPress/gutenberg#79881) - Docs: Clarify release recovery steps (WordPress/gutenberg#79884) - Widgets: auto-save inline attribute edits (WordPress/gutenberg#79808) - Classic block: Remove migration notice and restore inserter availability (WordPress/gutenberg#79894) - Media: enable uploading images inserted by URL (WordPress/gutenberg#79409) - Editor: saveDirtyEntities: don't allow onSave to filter records (WordPress/gutenberg#79850) - Theme: Use token reference as docs source (WordPress/gutenberg#79829) - RTC: Add RTC WebSocket tests to CI (WordPress/gutenberg#79757) - Components: migrate Flex to SCSS module (WordPress/gutenberg#79450) - Collaboration: only report changed properties from the default sync config (WordPress/gutenberg#79908) - ThemeProvider: Document wrapper customization scope (WordPress/gutenberg#79763) - Backfill unreleased changelog entries for the widget packages (WordPress/gutenberg#79909) - Remove unused FocalPointPicker style.scss (WordPress/gutenberg#79902) - SelectControl: Hard deprecate 40px default size (WordPress/gutenberg#79797) - Github workflows: extend package changelog nudge to bundled packages (WordPress/gutenberg#78934) - DimensionControl: Include styles in stylesheet (WordPress/gutenberg#79916) - Skip flakey collaboration e2e test (WordPress/gutenberg#79922) - Backport Changelog: Link Core PR WordPress/gutenberg#12007 for WordPress/gutenberg#75793 (WordPress/gutenberg#78786) - Block Style Variations: Simplify block style variation selector regex (WordPress/gutenberg#79924) - View Config: Add version handling (WordPress/gutenberg#79809) - HTML Block: Preserve innerContent when transforming to group, columns (WordPress/gutenberg#79887) - remove layout settings from widget dashboard (WordPress/gutenberg#79903) - Components: migrate Theme away from Emotion (WordPress/gutenberg#79447) - Blocks package: Stabilize `cloneSanitizedBlock` and `sanitizeBlockAttributes` (WordPress/gutenberg#79928) - Move real-time collaboration compat code to wordpress-7.1 (WordPress/gutenberg#79863) - Button: Fix focus ring for link (WordPress/gutenberg#79837) - Fix: DataForm inspector shows raw "auto-draft" status for new posts (WordPress/gutenberg#79914) - Block Supports: Prevent Additional CSS duplication inside Query Loop (WordPress/gutenberg#78282) - Code Quality: Use modern PHP string functions instead of strpos/substr (WordPress/gutenberg#79927) - Playlist: seek value text localization (WordPress/gutenberg#79834) - Code Quality: Use null coalescing operator instead of isset() ternaries (WordPress/gutenberg#79946) - Block editor: Fix clipped/doubled focus outline on inserter block list items (WordPress/gutenberg#79845) - Lint-staged: Match lint:css file globs (WordPress/gutenberg#79918) - Latest Posts: Parse blocks in full content display (WordPress/gutenberg#74866) - Block Editor: Share block-bindings context assembly between call sites (WordPress/gutenberg#79855) - Stylelint: Enforce class naming for all stylesheets (WordPress/gutenberg#79900) - Components: migrate Spacer to SCSS module (WordPress/gutenberg#79449) - Design system MCP: Document Codex CLI prerequisite for MCP setup (WordPress/gutenberg#79917) - NumberControl: Hard deprecate 40px default size (WordPress/gutenberg#79861) - Remove unused customizer-edit-widgets-initializer style.scss (WordPress/gutenberg#79915) - stylelint-config: Convert config to ESM (WordPress/gutenberg#79755) - Button: Fix suppressed ESLint errors (WordPress/gutenberg#79944) - Replace user-based authentication with a GitHub App for release-related logic (WordPress/gutenberg#79912) - Set selection before typing in RTC stress test (WordPress/gutenberg#79954) - Navigation Link/Submenu: run should-render check also without gutenberg plugin (WordPress/gutenberg#79748) - Rich Text: Move RichTextShortcut and RichTextInputEvent into @wordpress/rich-text (WordPress/gutenberg#79828) - Docs: Generalize the `npx` guidance in AGENTS.md to cover `wp-scripts` (WordPress/gutenberg#79973) - Media: Fix fatal error from narrowed create_item_from_url() visibility (WordPress/gutenberg#79972) - Editor: render back button as true <Button> and remove custom CSS (WordPress/gutenberg#79862) - SandBox: Inject resize script into head to stop it leaking as text (WordPress/gutenberg#79920) - Tabs: Remove editor-only block context (WordPress/gutenberg#79848) - Allow setting viewport tablet and mobile values in theme.json (WordPress/gutenberg#79104) - Media Inserter: Guard attach, detach, and invalidate behind a ! isExternalResource check (WordPress/gutenberg#79978) - BorderBoxControl: Fix unlink button positioning after View Emotion migration (WordPress/gutenberg#79967) - List: Fix suppressed ESLint errors (WordPress/gutenberg#79983) - Media Modals: Invalidate attachment caches when closing the modal (WordPress/gutenberg#79844) - Perf tests: wait for upload queue to settle between media-upload iterations (WordPress/gutenberg#79952) - GIF block variation: Remove icons from "Display as" toolbar buttons and only show when block can be inserted (WordPress/gutenberg#79985) - Stylelint: Lint all CSS file extensions (WordPress/gutenberg#79957) - Project automation: Stop flagging returning contributors as first-timers when they use hidden email addresses (WordPress/gutenberg#79987) - PHP-Only blocks: forward current post ID to server render (WordPress/gutenberg#78909) - Widget Dashboard: reserve paint space for tile focus rings (WordPress/gutenberg#79990) - Playlist: Show album art thumbnails (WordPress/gutenberg#79942) - Editor: Preload the view config form request for the DataForm inspector (WordPress/gutenberg#79910) - Properly configure Git user metadata for new app. (WordPress/gutenberg#80005) - Site Editor v2 experiment: correctly hide admin bar in distraction-free mode (WordPress/gutenberg#79937) - Switch from App ID to App user ID in git metadata. (WordPress/gutenberg#80006) - Playlist block: Avoid laggy layout shift when changing tracks (WordPress/gutenberg#79497) - Add ariaLabel supports for Tab List Block (WordPress/gutenberg#79948) - Restore responsive editing viewport dropdown copy changes (WordPress/gutenberg#79999) - Enable default gap processing on Gallery block (WordPress/gutenberg#79984) - Hide block toolbar slots when editing a responsive style state (WordPress/gutenberg#79998) - Tabs: Fix active tab switching from a stale inner-block selection (WordPress/gutenberg#79981) - Added Missing Global Documentation (WordPress/gutenberg#80033) - Media editor: address accessibility review feedback (WordPress/gutenberg#79966) - Build: Fix non-breaking npm audit vulnerability alerts (WordPress/gutenberg#79886) - Style Book: Pass site editor settings to StyleBookPreview on the styles route (WordPress/gutenberg#80035) - Editor: Fix regression and restore the back button focus ring (WordPress/gutenberg#80029) - Editor: render mobile back button as proper <Button> and remove custom CSS (WordPress/gutenberg#80032) - Style Book: Migrate to Tabs from @wordpress/ui (WordPress/gutenberg#80040) - Document widget relevance, help (WordPress/gutenberg#80007) - Visual revisions: Label autosaves in the revisions timeline (WordPress/gutenberg#79950) - Fix flaky "can use appender in site editor sidebar list view" e2e test (WordPress/gutenberg#80044) - Theme: Fix token story swatch accessibility (WordPress/gutenberg#79960) - Global Styles: Show skeleton placeholder while previews load (WordPress/gutenberg#79849) - Theme: Fill semantic token state gaps (WordPress/gutenberg#79770) - Theme: Document accessibility responsibilities (WordPress/gutenberg#79943) - Theme: Restrict seed colors to opaque values (WordPress/gutenberg#79773) - Theme: Document token naming grammar (WordPress/gutenberg#79769) - RTC: Only apply CRDT updates synchronously when collaborating (WordPress/gutenberg#79991) - Bump docker/login-action from 4.2.0 to 4.4.0 in /.github/workflows in the github-actions group across 1 directory (WordPress/gutenberg#80047) - Packages: Widen React peer dependency support to include React 19 (WordPress/gutenberg#80024) - Tabs: track overflow by observing each tab, mirroring Base UI (WordPress/gutenberg#79856) - Theme: Update design token format links (WordPress/gutenberg#80052) - design-system-mcp: Use fixed version for alpha MCP server (WordPress/gutenberg#80061) - Fix global gap styles for Gallery block (WordPress/gutenberg#80030) - Notes: Add a "Resolved" divider above resolved notes (WordPress/gutenberg#80019) - Checkbox: Add form primitive to @wordpress/ui (WordPress/gutenberg#80039) - InputControl: Hard deprecate 40px default size (WordPress/gutenberg#79962) - Panel: fix focus style for toggle button (WordPress/gutenberg#80064) - GIF to video conversion: make it opt-in. Switching via block transforms (WordPress/gutenberg#80072) - Theme: Make @wordpress/theme ESM only (WordPress/gutenberg#80063) - theme: Clarify package docs (WordPress/gutenberg#79961) - Fix focus ring for document bar (WordPress/gutenberg#80084) - Visual revisions: Make the autosave notice work with the visual revisions UI (WordPress/gutenberg#79947) - Fix flaky 'Activate theme' e2e test (WordPress/gutenberg#80090) - Fix playlist artwork removal on track switch (WordPress/gutenberg#80025) - Move styles into specific waveform styles dropdown area (WordPress/gutenberg#80060) - stylelint-config: Enable token fallback rule (WordPress/gutenberg#79768) - Fix flashing track state when adding new track (WordPress/gutenberg#80076) - Icons: Filter the icon library picker by collection (WordPress/gutenberg#79681) - Post editor: always iframe (WordPress/gutenberg#74042) - A11y: replace local aria-live regions with speak() (WordPress/gutenberg#79600) - Generalize playlist block wording (WordPress/gutenberg#80071) - Docs: Add missing @PARAM and @return tags to REST API compat functions (WordPress/gutenberg#80079) - Guidelines: Add Blocks as a registry scope (WordPress/gutenberg#79709) - Allow font size customization (WordPress/gutenberg#80069) - UI: Restore Link focus styles (WordPress/gutenberg#80091) - Editor: use the DS focus color for all sidebar elements (WordPress/gutenberg#80087) - File Block: Changed the context for fetching the media (WordPress/gutenberg#80085) - Theme: Remove elevation tokens (WordPress/gutenberg#80099) - Build: Upgrade to TypeScript 7.0 (WordPress/gutenberg#80083) - Connectors: add application password settings UI (WordPress/gutenberg#79403) - Icons: Unify collection-scoping route param on `collection` and validate description (WordPress/gutenberg#80113) - Add translation comment to waveform styles (WordPress/gutenberg#80112) - Playlist: use PlainText v2 to avoid HTML entities (WordPress/gutenberg#80068) - Move inspector controls styles slot back to previous position (WordPress/gutenberg#80111) - Fix playlist waveform artist rendering (WordPress/gutenberg#80104) - Fix linting of waveform test (WordPress/gutenberg#80124) - Theme: Document and test build plugin transform boundaries (WordPress/gutenberg#80088) - CODEOWNERS: Exclude eslint suppressions.json from /tools ownership (WordPress/gutenberg#80125) - Second click or space/enter keypress on playing track pauses it (WordPress/gutenberg#80066) - Theme: Cover display contents wrapper focus behavior (WordPress/gutenberg#80056) - wp-build: Allow @wordpress/theme 1.x peer versions (WordPress/gutenberg#80089) - Writing flow: fix selection end mapping at block boundaries (WordPress/gutenberg#80126) - Components: link recommended UI component (WordPress/gutenberg#80127) - Typewriter: remove the block selection gate (WordPress/gutenberg#80130) - useMergeRefs: apply ref changes after out-of-render attachment (WordPress/gutenberg#80133) - Observe typing on the writing flow node (WordPress/gutenberg#80131) - Components/Button: Don't use box-shadow for secondary buttons (WordPress/gutenberg#79982) - DataViews: Add a richtext control backed by a private RichTextControl shell in @wordpress/components (WordPress/gutenberg#78471) - Apply and correct EXIF orientation for client side sub-sizes (WordPress/gutenberg#79384) - Fix typo in inline comment in `collaboration.php` (WordPress/gutenberg#80147) - Media Inserter: Allow core media categories to subscribe to changes (WordPress/gutenberg#79921) - Accordion block: add background gradient support (WordPress/gutenberg#79840) - Rich text: synchronize the selection before events that consume it (WordPress/gutenberg#80151) - Quote block: add background gradient support (WordPress/gutenberg#79843) - Add option to exclude current post from query block (WordPress/gutenberg#64916) - Pullquote block: add background gradient support (WordPress/gutenberg#79841) - Block Supports: Ensure that custom CSS is output after the block library styles (WordPress/gutenberg#80062) - Rich text: cut through the record instead of execCommand (WordPress/gutenberg#80155) - Media Inserter: Add pagination to core media inserter categories (WordPress/gutenberg#80038) - Responsive editing: Add a Tooltip to the viewport / states badge (WordPress/gutenberg#80080) - Scripts: Make 'test-e2e' run Playwright and remove Puppeteer (WordPress/gutenberg#80058) - Post Content block: add background gradient support (WordPress/gutenberg#79842) - Notes: Remove snackbar when resolving or reopening a note (WordPress/gutenberg#80017) - Enable text alignment to be set by viewport state (WordPress/gutenberg#80037) - Preview dropdown: simplify viewport style state descriptions (WordPress/gutenberg#80146) - File Block: Deduplicate the file to audio/video/image transforms (WordPress/gutenberg#80158) - Responsive editing: Show crop dimensions on image block placeholder (WordPress/gutenberg#80162) - Add missing docblocks to client-assets.php (WordPress/gutenberg#80135) - Move typescript and rimraf out of the root package.json (WordPress/gutenberg#80086) - Release: Harden latest npm metadata publishing (WordPress/gutenberg#79904) - Add Playlist icon. (WordPress/gutenberg#80168) - Sync changes from core for view-config version handling (WordPress/gutenberg#80170) - CODEOWNERS: Exclude stylelint suppressions.json from /tools ownership (WordPress/gutenberg#80171) - Editor: only show back button focus ring on :focus-visible (WordPress/gutenberg#80114) - Release: Harden plugin release workflow guardrails (WordPress/gutenberg#79858) - Icons: Add "sites" icon. (WordPress/gutenberg#80094) - Flaky tests: fix widgets global inserter (WordPress/gutenberg#80177) - Release: Harden all npm package release paths (WordPress/gutenberg#79905) - Update `actionlint` to version `1.7.12`. (WordPress/gutenberg#79833) - Flaky tests: fix rich text backtick undo (WordPress/gutenberg#80183) - Button: hide Core focus ring when button as link is pressed (WordPress/gutenberg#80082) - Term Name: Migrate to textAlign block support (WordPress/gutenberg#76581) - Cover: allow restricting video embed providers (WordPress/gutenberg#80092) - Playlist icon: Fix bug with missing viewbox. (WordPress/gutenberg#80180) - Use playlist icon for Playlist block (WordPress/gutenberg#80174) - Build: Make installed-deps check layout-agnostic and surface opt-out env var (WordPress/gutenberg#79687) - Blocks: Rename _gutenberg_apply_content_filters() to _wp_apply_content_filters() (WordPress/gutenberg#80191) - Tabs: Wrap tab list onto multiple lines by default (WordPress/gutenberg#80097) - Flaky tests: fix writing flow arrow navigation (WordPress/gutenberg#80179) - Theme: Use public design token stylesheet imports (WordPress/gutenberg#80050) - Simplify playlist waveform metadata updates (WordPress/gutenberg#80193) - Notes: Support inline rich text (bold, italic, link, code) (WordPress/gutenberg#78242) - Playlist Block: Add artwork to play button (WordPress/gutenberg#79938) - Cover Block: Fix unsaveable state when clearing an embed video background (WordPress/gutenberg#80184) - DS: Name font weight tokens by intent (WordPress/gutenberg#80093) - theme: Validate npm publish surface (WordPress/gutenberg#79552) - Theme: Remove experimental package messaging (WordPress/gutenberg#80049) - Playlist Block: add waveform and waveform background color options (WordPress/gutenberg#80065) - Add more workflow file static analysis with Zizmor (WordPress/gutenberg#71523) - Block Editor: Simplify layout panel selector getter (WordPress/gutenberg#80176) - Media Inserter: Omit page arg from requests for the first set of results (WordPress/gutenberg#80219) - Notes: Add @mention autocomplete (WordPress/gutenberg#79604) - Latest Posts: Fix slow category selection with large category lists (WordPress/gutenberg#80198) - Block visibility: add theme json opt out (WordPress/gutenberg#76559) - Add an `editableRoot` block support for native cross-block selection (WordPress/gutenberg#79105) - Notes: Allow canceling the autocompleter popover with Escape without dismissing the note form (WordPress/gutenberg#80224) - Add contrast checking for viewport and pseudo states (WordPress/gutenberg#80223) - Blocks: Rename _wp_apply_content_filters() to _wp_apply_block_content_filters() (WordPress/gutenberg#80225) - Widget Primitives: Add a field type registry for widget attributes (WordPress/gutenberg#80148) - Icon block: When the default icon is unregistered, nothing is displayed (WordPress/gutenberg#80166) - Make the Playlist blocks stable (WordPress/gutenberg#80203) - Autocomplete: Use regular weight for result items (WordPress/gutenberg#80196) - Make pause button visually same size as play button (WordPress/gutenberg#80217) - Editor: Render post preview action as a menu item (WordPress/gutenberg#80195) - Release: Fail changelog generation cleanly (WordPress/gutenberg#80175) - Stabilize Tabs block (WordPress/gutenberg#80163) - Theme: Correct documented default background seed (WordPress/gutenberg#80237) - Block Supports: Improve handling of block class name to avoid fatal (WordPress/gutenberg#80214) - Rename 'Responsive editing' toggle to 'Responsive styles' (WordPress/gutenberg#80241) - Release: Make npm publishing rerunnable (WordPress/gutenberg#80187) - Only include icon library SVGs listed as `public` in the Zip file published to GitHub Container Registry for `wordpress-develop` (WordPress/gutenberg#79338) Props desrosj, wildworks. Fixes #65529. git-svn-id: https://develop.svn.wordpress.org/trunk@62739 602fd350-edb4-49c9-b593-d223f7449a82
This updates the pinned commit hash of the Gutenberg repository from `b5574edc8a952b2f1e528693761a97b1b3b580eb` (version `23.5.0`) to `2872d71cde528d82675f14862a1b84e2b8abbaea` (version `23.6.0 RC1`). A full list of changes included in this commit can be found on GitHub: https://github.com/WordPress/gutenberg/compare/v23.5.0..v23.6.0-rc.1. - IconButton: Use length zero for inline padding (WordPress/gutenberg#79722) - Button: Align focus styles with design system (WordPress/gutenberg#78646) - Remove playlist border radius support (WordPress/gutenberg#79753) - ExternalLink: Stop setting default rel (WordPress/gutenberg#79743) - Icons: Validate SVG icons include currentColor (WordPress/gutenberg#79751) - Tests: Fix flaky 'GIF to Video' e2e test (WordPress/gutenberg#79758) - CSS: Follow-up fixes to split_selector_list() (WordPress/gutenberg#79723) - Automated Testing: Enforce no-unresolved checks for test files (WordPress/gutenberg#79718) - Fix and permit unitless zeros used in CSS `calc` functions (WordPress/gutenberg#79786) - Components: migrate View away from Emotion (WordPress/gutenberg#79443) - Badge: update storybook with "don't use icons" example (WordPress/gutenberg#79585) - Tabs: Prevent tab list from moving focus during revision navigation (WordPress/gutenberg#79730) - Embed: Refactor 'EmbedPlaceholder' to use recommended components (WordPress/gutenberg#79759) - RTC: Remove collaboration notification defaults filter (WordPress/gutenberg#79771) - Tests: Honor waitForUploadQueueEmpty timeout in client-side media (WordPress/gutenberg#79783) - lintstaged: Avoid appending filenames to the `prelint:js` command (WordPress/gutenberg#79800) - Guidelines: Render block icons like the editor so every icon displays correctly (WordPress/gutenberg#79738) - Isolated mode: Fix bin resolution, type mismatch, and missing dependencies (WordPress/gutenberg#79806) - Duotone: Use HTML API class_list for duotone wrapper class handling (WordPress/gutenberg#79531) - Deprecate `@wordpress/reusable-blocks` public APIs (WordPress/gutenberg#79805) - UI: add LinkButton (WordPress/gutenberg#78944) - Block Library: Replace obsolete `View` primitive with plain `div` (WordPress/gutenberg#79767) - Site Editor: Update default theme color from fresh to modern (WordPress/gutenberg#79814) - Prevent overscroll bounce for stage and inspector surfaces (WordPress/gutenberg#78587) - Widgets: add attribute `relevance` and inline editing in the tile toolbar (WordPress/gutenberg#79735) - Automated Testing: Configure lint:css to report needless disables (WordPress/gutenberg#79788) - FormTokenField: Hard deprecate 40px default size (WordPress/gutenberg#79720) - UnitControl: Hard deprecate 40px default size (WordPress/gutenberg#79721) - Omnibar: move the 'site icon in admin bar' feature from experiment to 7.1 compat (WordPress/gutenberg#79807) - Update waveform player dependency to bring in upstream a11y improvements (WordPress/gutenberg#79825) - Backport changelog and package version updates from NPM (WordPress/gutenberg#79816) - Block variations: Support innerContent for the Custom HTML block (WordPress/gutenberg#79659) - Packages: Polish release changelog headings (WordPress/gutenberg#79826) - Theme: Clarify focus token naming docs (WordPress/gutenberg#79764) - Media: Return the filtered `wp_editor_set_quality` value in the upload response (WordPress/gutenberg#78420) - Media: Backport client-side media improvements from WordPress core backports (WordPress/gutenberg#79603) - Dynamic Gallery Block: Add a dynamic mode of the gallery block (WordPress/gutenberg#78796) - Global Styles: Match block panel order to the block inspector (WordPress/gutenberg#79794) - Verse block: add background gradient support (WordPress/gutenberg#79391) - UI: Add Skeleton component (WordPress/gutenberg#79671) - Widgets: add a declarative `help` metadata field, surfaced as a header infotip (WordPress/gutenberg#79830) - CustomSelectControl: Hard deprecate 40px default size (WordPress/gutenberg#79796) - Use subscribeDelegatedListener for selectionchange in rich text (WordPress/gutenberg#79712) - Vips: preserve bit depth of high-bit-depth AVIF in sub-sizes (WordPress/gutenberg#79556) - DataViews: Fix infinite-scroll jump on async page loads (WordPress/gutenberg#79546) - Added Missing Global Documentation (WordPress/gutenberg#79827) - Vips: Add positional-crop test for high-bit-depth AVIF (WordPress/gutenberg#79880) - Responsive style states: Update responsive editing help text and avoid showing desktop badge (WordPress/gutenberg#79615) - Packages: Update Ariakit to 0.4.32 (WordPress/gutenberg#79860) - Block position: Allow options dropdown to flip (WordPress/gutenberg#79798) - Command Palette: show the search icon on desktop as well (WordPress/gutenberg#79881) - Docs: Clarify release recovery steps (WordPress/gutenberg#79884) - Widgets: auto-save inline attribute edits (WordPress/gutenberg#79808) - Classic block: Remove migration notice and restore inserter availability (WordPress/gutenberg#79894) - Media: enable uploading images inserted by URL (WordPress/gutenberg#79409) - Editor: saveDirtyEntities: don't allow onSave to filter records (WordPress/gutenberg#79850) - Theme: Use token reference as docs source (WordPress/gutenberg#79829) - RTC: Add RTC WebSocket tests to CI (WordPress/gutenberg#79757) - Components: migrate Flex to SCSS module (WordPress/gutenberg#79450) - Collaboration: only report changed properties from the default sync config (WordPress/gutenberg#79908) - ThemeProvider: Document wrapper customization scope (WordPress/gutenberg#79763) - Backfill unreleased changelog entries for the widget packages (WordPress/gutenberg#79909) - Remove unused FocalPointPicker style.scss (WordPress/gutenberg#79902) - SelectControl: Hard deprecate 40px default size (WordPress/gutenberg#79797) - Github workflows: extend package changelog nudge to bundled packages (WordPress/gutenberg#78934) - DimensionControl: Include styles in stylesheet (WordPress/gutenberg#79916) - Skip flakey collaboration e2e test (WordPress/gutenberg#79922) - Backport Changelog: Link Core PR WordPress/gutenberg#12007 for WordPress/gutenberg#75793 (WordPress/gutenberg#78786) - Block Style Variations: Simplify block style variation selector regex (WordPress/gutenberg#79924) - View Config: Add version handling (WordPress/gutenberg#79809) - HTML Block: Preserve innerContent when transforming to group, columns (WordPress/gutenberg#79887) - remove layout settings from widget dashboard (WordPress/gutenberg#79903) - Components: migrate Theme away from Emotion (WordPress/gutenberg#79447) - Blocks package: Stabilize `cloneSanitizedBlock` and `sanitizeBlockAttributes` (WordPress/gutenberg#79928) - Move real-time collaboration compat code to wordpress-7.1 (WordPress/gutenberg#79863) - Button: Fix focus ring for link (WordPress/gutenberg#79837) - Fix: DataForm inspector shows raw "auto-draft" status for new posts (WordPress/gutenberg#79914) - Block Supports: Prevent Additional CSS duplication inside Query Loop (WordPress/gutenberg#78282) - Code Quality: Use modern PHP string functions instead of strpos/substr (WordPress/gutenberg#79927) - Playlist: seek value text localization (WordPress/gutenberg#79834) - Code Quality: Use null coalescing operator instead of isset() ternaries (WordPress/gutenberg#79946) - Block editor: Fix clipped/doubled focus outline on inserter block list items (WordPress/gutenberg#79845) - Lint-staged: Match lint:css file globs (WordPress/gutenberg#79918) - Latest Posts: Parse blocks in full content display (WordPress/gutenberg#74866) - Block Editor: Share block-bindings context assembly between call sites (WordPress/gutenberg#79855) - Stylelint: Enforce class naming for all stylesheets (WordPress/gutenberg#79900) - Components: migrate Spacer to SCSS module (WordPress/gutenberg#79449) - Design system MCP: Document Codex CLI prerequisite for MCP setup (WordPress/gutenberg#79917) - NumberControl: Hard deprecate 40px default size (WordPress/gutenberg#79861) - Remove unused customizer-edit-widgets-initializer style.scss (WordPress/gutenberg#79915) - stylelint-config: Convert config to ESM (WordPress/gutenberg#79755) - Button: Fix suppressed ESLint errors (WordPress/gutenberg#79944) - Replace user-based authentication with a GitHub App for release-related logic (WordPress/gutenberg#79912) - Set selection before typing in RTC stress test (WordPress/gutenberg#79954) - Navigation Link/Submenu: run should-render check also without gutenberg plugin (WordPress/gutenberg#79748) - Rich Text: Move RichTextShortcut and RichTextInputEvent into @wordpress/rich-text (WordPress/gutenberg#79828) - Docs: Generalize the `npx` guidance in AGENTS.md to cover `wp-scripts` (WordPress/gutenberg#79973) - Media: Fix fatal error from narrowed create_item_from_url() visibility (WordPress/gutenberg#79972) - Editor: render back button as true <Button> and remove custom CSS (WordPress/gutenberg#79862) - SandBox: Inject resize script into head to stop it leaking as text (WordPress/gutenberg#79920) - Tabs: Remove editor-only block context (WordPress/gutenberg#79848) - Allow setting viewport tablet and mobile values in theme.json (WordPress/gutenberg#79104) - Media Inserter: Guard attach, detach, and invalidate behind a ! isExternalResource check (WordPress/gutenberg#79978) - BorderBoxControl: Fix unlink button positioning after View Emotion migration (WordPress/gutenberg#79967) - List: Fix suppressed ESLint errors (WordPress/gutenberg#79983) - Media Modals: Invalidate attachment caches when closing the modal (WordPress/gutenberg#79844) - Perf tests: wait for upload queue to settle between media-upload iterations (WordPress/gutenberg#79952) - GIF block variation: Remove icons from "Display as" toolbar buttons and only show when block can be inserted (WordPress/gutenberg#79985) - Stylelint: Lint all CSS file extensions (WordPress/gutenberg#79957) - Project automation: Stop flagging returning contributors as first-timers when they use hidden email addresses (WordPress/gutenberg#79987) - PHP-Only blocks: forward current post ID to server render (WordPress/gutenberg#78909) - Widget Dashboard: reserve paint space for tile focus rings (WordPress/gutenberg#79990) - Playlist: Show album art thumbnails (WordPress/gutenberg#79942) - Editor: Preload the view config form request for the DataForm inspector (WordPress/gutenberg#79910) - Properly configure Git user metadata for new app. (WordPress/gutenberg#80005) - Site Editor v2 experiment: correctly hide admin bar in distraction-free mode (WordPress/gutenberg#79937) - Switch from App ID to App user ID in git metadata. (WordPress/gutenberg#80006) - Playlist block: Avoid laggy layout shift when changing tracks (WordPress/gutenberg#79497) - Add ariaLabel supports for Tab List Block (WordPress/gutenberg#79948) - Restore responsive editing viewport dropdown copy changes (WordPress/gutenberg#79999) - Enable default gap processing on Gallery block (WordPress/gutenberg#79984) - Hide block toolbar slots when editing a responsive style state (WordPress/gutenberg#79998) - Tabs: Fix active tab switching from a stale inner-block selection (WordPress/gutenberg#79981) - Added Missing Global Documentation (WordPress/gutenberg#80033) - Media editor: address accessibility review feedback (WordPress/gutenberg#79966) - Build: Fix non-breaking npm audit vulnerability alerts (WordPress/gutenberg#79886) - Style Book: Pass site editor settings to StyleBookPreview on the styles route (WordPress/gutenberg#80035) - Editor: Fix regression and restore the back button focus ring (WordPress/gutenberg#80029) - Editor: render mobile back button as proper <Button> and remove custom CSS (WordPress/gutenberg#80032) - Style Book: Migrate to Tabs from @wordpress/ui (WordPress/gutenberg#80040) - Document widget relevance, help (WordPress/gutenberg#80007) - Visual revisions: Label autosaves in the revisions timeline (WordPress/gutenberg#79950) - Fix flaky "can use appender in site editor sidebar list view" e2e test (WordPress/gutenberg#80044) - Theme: Fix token story swatch accessibility (WordPress/gutenberg#79960) - Global Styles: Show skeleton placeholder while previews load (WordPress/gutenberg#79849) - Theme: Fill semantic token state gaps (WordPress/gutenberg#79770) - Theme: Document accessibility responsibilities (WordPress/gutenberg#79943) - Theme: Restrict seed colors to opaque values (WordPress/gutenberg#79773) - Theme: Document token naming grammar (WordPress/gutenberg#79769) - RTC: Only apply CRDT updates synchronously when collaborating (WordPress/gutenberg#79991) - Bump docker/login-action from 4.2.0 to 4.4.0 in /.github/workflows in the github-actions group across 1 directory (WordPress/gutenberg#80047) - Packages: Widen React peer dependency support to include React 19 (WordPress/gutenberg#80024) - Tabs: track overflow by observing each tab, mirroring Base UI (WordPress/gutenberg#79856) - Theme: Update design token format links (WordPress/gutenberg#80052) - design-system-mcp: Use fixed version for alpha MCP server (WordPress/gutenberg#80061) - Fix global gap styles for Gallery block (WordPress/gutenberg#80030) - Notes: Add a "Resolved" divider above resolved notes (WordPress/gutenberg#80019) - Checkbox: Add form primitive to @wordpress/ui (WordPress/gutenberg#80039) - InputControl: Hard deprecate 40px default size (WordPress/gutenberg#79962) - Panel: fix focus style for toggle button (WordPress/gutenberg#80064) - GIF to video conversion: make it opt-in. Switching via block transforms (WordPress/gutenberg#80072) - Theme: Make @wordpress/theme ESM only (WordPress/gutenberg#80063) - theme: Clarify package docs (WordPress/gutenberg#79961) - Fix focus ring for document bar (WordPress/gutenberg#80084) - Visual revisions: Make the autosave notice work with the visual revisions UI (WordPress/gutenberg#79947) - Fix flaky 'Activate theme' e2e test (WordPress/gutenberg#80090) - Fix playlist artwork removal on track switch (WordPress/gutenberg#80025) - Move styles into specific waveform styles dropdown area (WordPress/gutenberg#80060) - stylelint-config: Enable token fallback rule (WordPress/gutenberg#79768) - Fix flashing track state when adding new track (WordPress/gutenberg#80076) - Icons: Filter the icon library picker by collection (WordPress/gutenberg#79681) - Post editor: always iframe (WordPress/gutenberg#74042) - A11y: replace local aria-live regions with speak() (WordPress/gutenberg#79600) - Generalize playlist block wording (WordPress/gutenberg#80071) - Docs: Add missing @PARAM and @return tags to REST API compat functions (WordPress/gutenberg#80079) - Guidelines: Add Blocks as a registry scope (WordPress/gutenberg#79709) - Allow font size customization (WordPress/gutenberg#80069) - UI: Restore Link focus styles (WordPress/gutenberg#80091) - Editor: use the DS focus color for all sidebar elements (WordPress/gutenberg#80087) - File Block: Changed the context for fetching the media (WordPress/gutenberg#80085) - Theme: Remove elevation tokens (WordPress/gutenberg#80099) - Build: Upgrade to TypeScript 7.0 (WordPress/gutenberg#80083) - Connectors: add application password settings UI (WordPress/gutenberg#79403) - Icons: Unify collection-scoping route param on `collection` and validate description (WordPress/gutenberg#80113) - Add translation comment to waveform styles (WordPress/gutenberg#80112) - Playlist: use PlainText v2 to avoid HTML entities (WordPress/gutenberg#80068) - Move inspector controls styles slot back to previous position (WordPress/gutenberg#80111) - Fix playlist waveform artist rendering (WordPress/gutenberg#80104) - Fix linting of waveform test (WordPress/gutenberg#80124) - Theme: Document and test build plugin transform boundaries (WordPress/gutenberg#80088) - CODEOWNERS: Exclude eslint suppressions.json from /tools ownership (WordPress/gutenberg#80125) - Second click or space/enter keypress on playing track pauses it (WordPress/gutenberg#80066) - Theme: Cover display contents wrapper focus behavior (WordPress/gutenberg#80056) - wp-build: Allow @wordpress/theme 1.x peer versions (WordPress/gutenberg#80089) - Writing flow: fix selection end mapping at block boundaries (WordPress/gutenberg#80126) - Components: link recommended UI component (WordPress/gutenberg#80127) - Typewriter: remove the block selection gate (WordPress/gutenberg#80130) - useMergeRefs: apply ref changes after out-of-render attachment (WordPress/gutenberg#80133) - Observe typing on the writing flow node (WordPress/gutenberg#80131) - Components/Button: Don't use box-shadow for secondary buttons (WordPress/gutenberg#79982) - DataViews: Add a richtext control backed by a private RichTextControl shell in @wordpress/components (WordPress/gutenberg#78471) - Apply and correct EXIF orientation for client side sub-sizes (WordPress/gutenberg#79384) - Fix typo in inline comment in `collaboration.php` (WordPress/gutenberg#80147) - Media Inserter: Allow core media categories to subscribe to changes (WordPress/gutenberg#79921) - Accordion block: add background gradient support (WordPress/gutenberg#79840) - Rich text: synchronize the selection before events that consume it (WordPress/gutenberg#80151) - Quote block: add background gradient support (WordPress/gutenberg#79843) - Add option to exclude current post from query block (WordPress/gutenberg#64916) - Pullquote block: add background gradient support (WordPress/gutenberg#79841) - Block Supports: Ensure that custom CSS is output after the block library styles (WordPress/gutenberg#80062) - Rich text: cut through the record instead of execCommand (WordPress/gutenberg#80155) - Media Inserter: Add pagination to core media inserter categories (WordPress/gutenberg#80038) - Responsive editing: Add a Tooltip to the viewport / states badge (WordPress/gutenberg#80080) - Scripts: Make 'test-e2e' run Playwright and remove Puppeteer (WordPress/gutenberg#80058) - Post Content block: add background gradient support (WordPress/gutenberg#79842) - Notes: Remove snackbar when resolving or reopening a note (WordPress/gutenberg#80017) - Enable text alignment to be set by viewport state (WordPress/gutenberg#80037) - Preview dropdown: simplify viewport style state descriptions (WordPress/gutenberg#80146) - File Block: Deduplicate the file to audio/video/image transforms (WordPress/gutenberg#80158) - Responsive editing: Show crop dimensions on image block placeholder (WordPress/gutenberg#80162) - Add missing docblocks to client-assets.php (WordPress/gutenberg#80135) - Move typescript and rimraf out of the root package.json (WordPress/gutenberg#80086) - Release: Harden latest npm metadata publishing (WordPress/gutenberg#79904) - Add Playlist icon. (WordPress/gutenberg#80168) - Sync changes from core for view-config version handling (WordPress/gutenberg#80170) - CODEOWNERS: Exclude stylelint suppressions.json from /tools ownership (WordPress/gutenberg#80171) - Editor: only show back button focus ring on :focus-visible (WordPress/gutenberg#80114) - Release: Harden plugin release workflow guardrails (WordPress/gutenberg#79858) - Icons: Add "sites" icon. (WordPress/gutenberg#80094) - Flaky tests: fix widgets global inserter (WordPress/gutenberg#80177) - Release: Harden all npm package release paths (WordPress/gutenberg#79905) - Update `actionlint` to version `1.7.12`. (WordPress/gutenberg#79833) - Flaky tests: fix rich text backtick undo (WordPress/gutenberg#80183) - Button: hide Core focus ring when button as link is pressed (WordPress/gutenberg#80082) - Term Name: Migrate to textAlign block support (WordPress/gutenberg#76581) - Cover: allow restricting video embed providers (WordPress/gutenberg#80092) - Playlist icon: Fix bug with missing viewbox. (WordPress/gutenberg#80180) - Use playlist icon for Playlist block (WordPress/gutenberg#80174) - Build: Make installed-deps check layout-agnostic and surface opt-out env var (WordPress/gutenberg#79687) - Blocks: Rename _gutenberg_apply_content_filters() to _wp_apply_content_filters() (WordPress/gutenberg#80191) - Tabs: Wrap tab list onto multiple lines by default (WordPress/gutenberg#80097) - Flaky tests: fix writing flow arrow navigation (WordPress/gutenberg#80179) - Theme: Use public design token stylesheet imports (WordPress/gutenberg#80050) - Simplify playlist waveform metadata updates (WordPress/gutenberg#80193) - Notes: Support inline rich text (bold, italic, link, code) (WordPress/gutenberg#78242) - Playlist Block: Add artwork to play button (WordPress/gutenberg#79938) - Cover Block: Fix unsaveable state when clearing an embed video background (WordPress/gutenberg#80184) - DS: Name font weight tokens by intent (WordPress/gutenberg#80093) - theme: Validate npm publish surface (WordPress/gutenberg#79552) - Theme: Remove experimental package messaging (WordPress/gutenberg#80049) - Playlist Block: add waveform and waveform background color options (WordPress/gutenberg#80065) - Add more workflow file static analysis with Zizmor (WordPress/gutenberg#71523) - Block Editor: Simplify layout panel selector getter (WordPress/gutenberg#80176) - Media Inserter: Omit page arg from requests for the first set of results (WordPress/gutenberg#80219) - Notes: Add @mention autocomplete (WordPress/gutenberg#79604) - Latest Posts: Fix slow category selection with large category lists (WordPress/gutenberg#80198) - Block visibility: add theme json opt out (WordPress/gutenberg#76559) - Add an `editableRoot` block support for native cross-block selection (WordPress/gutenberg#79105) - Notes: Allow canceling the autocompleter popover with Escape without dismissing the note form (WordPress/gutenberg#80224) - Add contrast checking for viewport and pseudo states (WordPress/gutenberg#80223) - Blocks: Rename _wp_apply_content_filters() to _wp_apply_block_content_filters() (WordPress/gutenberg#80225) - Widget Primitives: Add a field type registry for widget attributes (WordPress/gutenberg#80148) - Icon block: When the default icon is unregistered, nothing is displayed (WordPress/gutenberg#80166) - Make the Playlist blocks stable (WordPress/gutenberg#80203) - Autocomplete: Use regular weight for result items (WordPress/gutenberg#80196) - Make pause button visually same size as play button (WordPress/gutenberg#80217) - Editor: Render post preview action as a menu item (WordPress/gutenberg#80195) - Release: Fail changelog generation cleanly (WordPress/gutenberg#80175) - Stabilize Tabs block (WordPress/gutenberg#80163) - Theme: Correct documented default background seed (WordPress/gutenberg#80237) - Block Supports: Improve handling of block class name to avoid fatal (WordPress/gutenberg#80214) - Rename 'Responsive editing' toggle to 'Responsive styles' (WordPress/gutenberg#80241) - Release: Make npm publishing rerunnable (WordPress/gutenberg#80187) - Only include icon library SVGs listed as `public` in the Zip file published to GitHub Container Registry for `wordpress-develop` (WordPress/gutenberg#79338) Props desrosj, wildworks. Fixes #65529. Built from https://develop.svn.wordpress.org/trunk@62739 git-svn-id: http://core.svn.wordpress.org/trunk@62023 1a063a9b-81f0-0310-95a4-ce76da25c4cd
|
I learned that @ryanwelcher has released a great repository to demonstrate how forcing an iframe can affect custom blocks. This repository will be very useful for developers who want to prepare for an iframe editor. |
What?
Consistently iframes the post editor. Fixes #54095. Fixes #65172.
Why?
We're sort of in a "damned if you do, damned if you don't" scenario.
Themes and plugins are used to having content appear in an iframe and often don't consider both iframed and non-iframe editors, which causes a lot of frustration when an editor suddenly switches to a non-iframed if the user installs a plugin with a API v1 or v2 block. For example: https://x.com/thekevingeary/status/1803760573718397081.
On the other hand we might cause some breakage for some blocks that don't render or function well in an iframe. Out of caution we disable the iframe when there any plugin adds any block that is less than version 3, even though they might function fine. (We check for installed blocks rather than inserted blocks because we don't want to flip this mid editing.)
We're probably at a point where far more breakage is caused by the inconsistency than blocks not functioning well with iframe.
Let's enforce the iframe early in Gutenberg so that we get early feedback about the non functioning blocks. That way we can work on one of the back-compat techniques described in #73138 (comment).
Note that in Gutenberg, we are already enforcing the iframe in the post editor when a theme is block-based. So within Gutenberg, this PR changes it so it's also enforced when a plugin installs non-v3 block AND there's a classic theme. Again, note that we already iframe when there's a classic theme and there's only v3 blocks (fresh install).
How?
Remove the conditions.
Testing Instructions
Testing Instructions for Keyboard
Screenshots or screencast