FINERACT-1932: Fineract modularization - fineract-charge - #3897
Merged
adamsaghy merged 1 commit intoMay 21, 2024
Conversation
adamsaghy
reviewed
May 21, 2024
Contributor
There was a problem hiding this comment.
The entity list of Fineract core module is longer. Please double check whether you have listed all!
Contributor
Author
There was a problem hiding this comment.
Done! Persistence files updated
adamsaghy
requested changes
May 21, 2024
adamsaghy
left a comment
adamsaghy
left a comment
Contributor
There was a problem hiding this comment.
Kindly check my comment!
alberto-art3ch
force-pushed
the
modularization/fineract-charge
branch
2 times, most recently
from
May 21, 2024 14:36
c9ee231 to
80665a1
Compare
alberto-art3ch
force-pushed
the
modularization/fineract-charge
branch
from
May 21, 2024 19:37
80665a1 to
bdd8544
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Create the initial
fineract-chargemodules - used as charge domain module classes, interfaces and servicesFINERACT-1932
Checklist
Please make sure these boxes are checked before submitting your pull request - thanks!
Write the commit message as per https://github.com/apache/fineract/#pull-requests
Acknowledge that we will not review PRs that are not passing the build ("green") - it is your responsibility to get a proposed PR to pass the build, not primarily the project's maintainers.
Create/update unit or integration tests for verifying the changes made.
Follow coding conventions at https://cwiki.apache.org/confluence/display/FINERACT/Coding+Conventions.
Add required Swagger annotation and update API documentation at fineract-provider/src/main/resources/static/legacy-docs/apiLive.htm with details of any API changes
Submission is not a "code dump". (Large changes can be made "in repository" via a branch. Ask on the developer mailing list for guidance, if required.)
FYI our guidelines for code reviews are at https://cwiki.apache.org/confluence/display/FINERACT/Code+Review+Guide.